Add 'Active' and 'My collections' tabs to tab between active and my collections
Closed, ResolvedPublic
Actions

Description

The name of the tab that is not my collections needs some input. @KHammerstein had suggested popular but 'active' or 'recent' or 'new' would make more sense, since popular is misleading.

Details

Subject	Repo	Branch	Lines +/-
i18n: Use same title across all collections	mediawiki/extensions/Gather	master	+1 -6
Render tabs to my collections and recent collections	mediawiki/extensions/Gather	master	+157 -9
i18n: Switch label and urls from active to recent	mediawiki/extensions/Gather	master	+5 -5
Render tabs to my collections and active collections	mediawiki/extensions/Gather	master	+81 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T101115 Anon users can access public view from main menu
Resolved	Jdlrobson	T101201 Notification for hamburger and tipsy in menu to call out collections
Resolved	Jdlrobson	T96222 Add a new public collection feed view
Resolved	Jdlrobson	T102188 Add 'Active' and 'My collections' tabs to tab between active and my collections
Resolved	• Jhernandez	T102983 Infinite scrolling on collections list broken (user collections vs active collections)

Event Timeline

Jdlrobson created this task.Jun 11 2015, 9:56 PM

Jdlrobson claimed this task.

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: Patch-For-Review, Mobile-Web-Sprint-49-Wayne's-World, Web-Team-Backlog, Mobile-Web-Design, Gather.

Jdlrobson moved this task from Needs Analysis to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.

Jdlrobson added subscribers: gerritbot, • KHammerstein, Jdlrobson and 2 others.

@Jdlrobson Can we name it popular? As a casual user, I don't know what active means

Let's talk. I pinged you on the other card about this. "Popular" is a lie since it doesn't reflect what it actually is... open to other ideas though.

Jdlrobson moved this task from Doing to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 11 2015, 11:48 PM

Jdlrobson moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.Jun 12 2015, 5:44 PM

I'm not sure why this is in the "Code review" column. I don't see a link to the patch or is it just a discussion task?

• bmansurov moved this task from Code Review to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 12 2015, 9:19 PM

It's https://gerrit.wikimedia.org/r/#/c/217751/

Jdlrobson moved this task from Doing to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 13 2015, 12:50 AM

Change 217751 had a related patch set uploaded (by Jdlrobson):
Render tabs to my collections and active collections

https://gerrit.wikimedia.org/r/217751

@Jdlrobson, @KHammerstein: I know that your discussion will be reflected in the patch, but could you please add the salient points of your conversation as a comment for posterity?

Moving this to -1 (Needs More Work) while T96222 is in there so people don't waste time trying to pick this up for review.

@KHammerstein I'm still waiting to resolve this. I was able to crap @JKatzWMF and he agreed popular didn't make sense here and would be better used when we have the following feature.

@phuedx fwiw i'm told wasting time is okay (I've had this conversation with @siebrand about experimental features - the important thing is uncovering translation issues such as gender early)

Jdlrobson reassigned this task from Jdlrobson to • KHammerstein.Jun 15 2015, 6:49 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson set Security to None.

Jdlrobson moved this task from Needs triage to This Sprint on the Gather board.Jun 15 2015, 11:15 PM

Change 217751 merged by jenkins-bot:
Render tabs to my collections and active collections

https://gerrit.wikimedia.org/r/217751

Jdlrobson mentioned this in rEGATa7a86d89eedb: Render tabs to my collections and active collections.Jun 16 2015, 5:06 PM

• Konfused-Kitten mentioned this in rMEXT150a7da7ce0a: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jun 16 2015, 5:06 PM

Jdlrobson mentioned this in T96222: Add a new public collection feed view.Jun 16 2015, 5:07 PM

@Jdlrobson "Recent" is ok with me. Sorry for the delay

Change 218664 had a related patch set uploaded (by Jdlrobson):
i18n: Switch label and urls from active to recent

https://gerrit.wikimedia.org/r/218664

Jdlrobson claimed this task.Jun 16 2015, 5:37 PM

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.

• Jhernandez moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 5:41 PM

https://gerrit.wikimedia.org/r/217751 (branch master): WMF-deploy-2015-06-16_(1.26wmf10)

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 8:14 PM

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.

Change 218731 had a related patch set uploaded (by Jdlrobson):
Render tabs to my collections and active collections

https://gerrit.wikimedia.org/r/218731

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 8:37 PM

Change 218664 abandoned by Jdlrobson:
i18n: Switch label and urls from active to recent

Reason:
Fixed up into https://gerrit.wikimedia.org/r/#/c/218731/

https://gerrit.wikimedia.org/r/218664

• bmansurov unsubscribed.Jun 16 2015, 8:42 PM

Blocked on https://gerrit.wikimedia.org/r/#/c/218729/1

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 17 2015, 5:40 PM

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 17 2015, 8:53 PM

The blocker has been merged.

• bmansurov moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 18 2015, 10:17 AM

• bmansurov moved this task from Ready for Signoff to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 18 2015, 10:19 AM

• Jhernandez added a subtask: T102983: Infinite scrolling on collections list broken (user collections vs active collections).Jun 18 2015, 5:57 PM

https://gerrit.wikimedia.org/r/218731 has a browser test issue I need to fix.

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 18 2015, 6:42 PM

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 18 2015, 9:07 PM

@KHammerstein @Jdlrobson, based on this ticket I thought you settled on 'recent', but now I see it showing as 'active' . People know what recent means and they can guess what popular means, but I think active is really hard to understand. Can it be switched to 'recent'?

It's active only on enwiki. We had to revert the changes that changed it to recent but sadly didn't do that in time. Track progress in T102188 - the code hasn't been merged.

Oh this is T102188 ;-)
yeh as you can see this is not in the 'Done' column yet. It's still being worked on so don't judge it yet...

• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 19 2015, 8:00 PM

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 19 2015, 9:00 PM

• Jhernandez moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 22 2015, 10:50 AM

Change 218731 merged by jenkins-bot:
Render tabs to my collections and recent collections

https://gerrit.wikimedia.org/r/218731

• Konfused-Kitten mentioned this in rMEXTe57dca3a5bc5: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jun 22 2015, 10:50 AM

• Konfused-Kitten mentioned this in rEGAT45d1b558645a: Render tabs to my collections and recent collections.

• KLans_WMF added a project: Reading-Web-Sprint-50-The-X-Files.Jun 22 2015, 4:25 PM

• Jhernandez moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-50-The-X-Files board.Jun 22 2015, 4:27 PM

https://gerrit.wikimedia.org/r/218731 (branch master): WMF-deploy-2015-06-23_(1.26wmf11)

• bmansurov unsubscribed.Jun 22 2015, 8:40 PM

Jdlrobson removed a project: Reading-Web-Sprint-50-The-X-Files.Jun 23 2015, 12:31 AM

@Jdlrobson

Title should be changed to just read "Collections" for both tabs. When I see "Collections by Kaitymh" and see the recent tab, I think it will just show my recent

@KHammerstein @Jdlrobson: I've moved this over to Reading-Web-Sprint-50-The-X-Files so that we can continue this conversation.

phuedx moved this task from Ready for Signoff to To Do on the Reading-Web-Sprint-50-The-X-Files board.Jun 25 2015, 1:30 PM

phuedx closed subtask T102983: Infinite scrolling on collections list broken (user collections vs active collections) as Resolved.Jun 25 2015, 1:37 PM

Change 220821 had a related patch set uploaded (by Jdlrobson):
i18n: Use same title across all collections

https://gerrit.wikimedia.org/r/220821

Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jun 25 2015, 9:51 PM

https://gerrit.wikimedia.org/r/#/c/220821/ is merged is this ready for signoff?

Change 220821 merged by jenkins-bot:
i18n: Use same title across all collections

https://gerrit.wikimedia.org/r/220821

• Konfused-Kitten mentioned this in rEGATf214773a0abe: i18n: Use same title across all collections.Jun 25 2015, 11:53 PM

Diffusion mentioned this in rMEXTfbc50e4bd8fb: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jun 25 2015, 11:53 PM

https://gerrit.wikimedia.org/r/220821 (branch master): WMF-deploy-2015-06-30_(1.26wmf12)

@rmoen
Not sure if this has been addressed

Title should be changed to just read "Collections" for both tabs. When I see "Collections by Kaitymh" and see the recent tab, I think it will just show my recent - could be confusing

phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-50-The-X-Files board.Jun 26 2015, 7:10 AM

@KHammerstein: I can confirm that this has been done, e.g. http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/all/recent and http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/by.