Page MenuHomePhabricator

Add 'Active' and 'My collections' tabs to tab between active and my collections
Closed, ResolvedPublic

Description

The name of the tab that is not my collections needs some input. @KHammerstein had suggested popular but 'active' or 'recent' or 'new' would make more sense, since popular is misleading.

Event Timeline

Jdlrobson claimed this task.
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)

@Jdlrobson Can we name it popular? As a casual user, I don't know what active means

Let's talk. I pinged you on the other card about this. "Popular" is a lie since it doesn't reflect what it actually is... open to other ideas though.

I'm not sure why this is in the "Code review" column. I don't see a link to the patch or is it just a discussion task?

Change 217751 had a related patch set uploaded (by Jdlrobson):
Render tabs to my collections and active collections

https://gerrit.wikimedia.org/r/217751

phuedx added a subscriber: phuedx.Jun 15 2015, 3:49 PM

@Jdlrobson, @KHammerstein: I know that your discussion will be reflected in the patch, but could you please add the salient points of your conversation as a comment for posterity?

Moving this to -1 (Needs More Work) while T96222 is in there so people don't waste time trying to pick this up for review.

@KHammerstein I'm still waiting to resolve this. I was able to crap @JKatzWMF and he agreed popular didn't make sense here and would be better used when we have the following feature.

@phuedx fwiw i'm told wasting time is okay (I've had this conversation with @siebrand about experimental features - the important thing is uncovering translation issues such as gender early)

Jdlrobson updated the task description. (Show Details)
Jdlrobson set Security to None.
Jdlrobson moved this task from Needs triage to This Sprint on the Gather board.Jun 15 2015, 11:15 PM

Change 217751 merged by jenkins-bot:
Render tabs to my collections and active collections

https://gerrit.wikimedia.org/r/217751

@Jdlrobson "Recent" is ok with me. Sorry for the delay

Change 218664 had a related patch set uploaded (by Jdlrobson):
i18n: Switch label and urls from active to recent

https://gerrit.wikimedia.org/r/218664

Change 218731 had a related patch set uploaded (by Jdlrobson):
Render tabs to my collections and active collections

https://gerrit.wikimedia.org/r/218731

Change 218664 abandoned by Jdlrobson:
i18n: Switch label and urls from active to recent

Reason:
Fixed up into https://gerrit.wikimedia.org/r/#/c/218731/

https://gerrit.wikimedia.org/r/218664

The blocker has been merged.

https://gerrit.wikimedia.org/r/218731 has a browser test issue I need to fix.

@KHammerstein @Jdlrobson, based on this ticket I thought you settled on 'recent', but now I see it showing as 'active' . People know what recent means and they can guess what popular means, but I think active is really hard to understand. Can it be switched to 'recent'?

It's active only on enwiki. We had to revert the changes that changed it to recent but sadly didn't do that in time. Track progress in T102188 - the code hasn't been merged.

Oh this is T102188 ;-)
yeh as you can see this is not in the 'Done' column yet. It's still being worked on so don't judge it yet...

Change 218731 merged by jenkins-bot:
Render tabs to my collections and recent collections

https://gerrit.wikimedia.org/r/218731

@Jdlrobson

Title should be changed to just read "Collections" for both tabs. When I see "Collections by Kaitymh" and see the recent tab, I think it will just show my recent

Change 220821 had a related patch set uploaded (by Jdlrobson):
i18n: Use same title across all collections

https://gerrit.wikimedia.org/r/220821

Change 220821 merged by jenkins-bot:
i18n: Use same title across all collections

https://gerrit.wikimedia.org/r/220821

@rmoen
Not sure if this has been addressed

Title should be changed to just read "Collections" for both tabs. When I see "Collections by Kaitymh" and see the recent tab, I think it will just show my recent - could be confusing