Border separating header from banners is limited by max-width, but banners are not
Closed, DuplicatePublic
Actions

Assigned To

Authored By

	kaldari
	Jun 11 2015, 10:13 PM

Description

See screenshot:

Screen Shot 2015-06-11 at 3.03.55 PM.png (505×1 px, 254 KB)

Probably we need to add a new div containing all notices (siteNotice, localNotice, mw-dismissable-notice) and set a bottom border on that with a -1px margin, or we need to put the header inside another div that is full width and apply the border to that.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Generalise the desktop max width css	mediawiki/extensions/MobileFrontend	master	+60 -101

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• rmoen	T101344 [EPIC] Push max-width and last modified work for mobile on desktop to stable
Resolved	Jdlrobson	T101313 Alpha, beta: Max-width in mobile should apply to all pages
Duplicate	Jdlrobson	T102190 Border separating header from banners is limited by max-width, but banners are not

Event Timeline

kaldari created this task.Jun 11 2015, 10:13 PM

kaldari raised the priority of this task from to Needs Triage.

kaldari updated the task description. (Show Details)

kaldari added projects: Web-Team-Backlog-Archived, Mobile-Web-Design.

kaldari subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2015, 10:13 PM

kaldari added a parent task: T101344: [EPIC] Push max-width and last modified work for mobile on desktop to stable.Jun 11 2015, 10:13 PM

kaldari added a project: Mobile-Web-Sprint-49-Wayne's-World.

kaldari set Security to None.

kaldari moved this task from Needs Analysis to To Do on the Mobile-Web-Sprint-49-Wayne's-World board.

• KLans_WMF moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog-Archived board.Jun 12 2015, 5:44 PM

Jdlrobson claimed this task.Jun 16 2015, 8:50 PM

Jdlrobson moved this task from To Do to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.

• bmansurov added a parent task: T101313: Alpha, beta: Max-width in mobile should apply to all pages.Jun 16 2015, 9:07 PM

Change 218781 had a related patch set uploaded (by Jdlrobson):
WIP: Generalise the desktop max width css

https://gerrit.wikimedia.org/r/218781

gerritbot added a project: Patch-For-Review.Jun 16 2015, 10:22 PM

Jdlrobson moved this task from Doing to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 10:22 PM

As can be seen in the patch https://gerrit.wikimedia.org/r/218781 the desktop max-width css has got a bit out of control. let's take time to clean this up. We can't possibly push it to production.

Open questions: What name captures all these elements (anyone got something better than skin-component?) as it is far too generic
Is there a better way to achieve the same goal?

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 17 2015, 11:09 PM

• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 17 2015, 11:44 PM

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 18 2015, 6:41 PM