Page MenuHomePhabricator

Border separating header from banners is limited by max-width, but banners are not
Closed, DuplicatePublic

Description

See screenshot:

Probably we need to add a new div containing all notices (siteNotice, localNotice, mw-dismissable-notice) and set a bottom border on that with a -1px margin, or we need to put the header inside another div that is full width and apply the border to that.

Event Timeline

kaldari created this task.Jun 11 2015, 10:13 PM
kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added a subscriber: kaldari.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2015, 10:13 PM
Jdlrobson moved this task from To Do to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.

Change 218781 had a related patch set uploaded (by Jdlrobson):
WIP: Generalise the desktop max width css

https://gerrit.wikimedia.org/r/218781

As can be seen in the patch https://gerrit.wikimedia.org/r/218781 the desktop max-width css has got a bit out of control. let's take time to clean this up. We can't possibly push it to production.

Open questions: What name captures all these elements (anyone got something better than skin-component?) as it is far too generic
Is there a better way to achieve the same goal?

Merged into other bug - much easier for me to track that way.

Change 218781 merged by jenkins-bot:
Generalise the desktop max width css

https://gerrit.wikimedia.org/r/218781