Nearby refresh icon huge
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 12 2015, 3:30 AM

Description

Somehow overlooked this when fixing search bug. Live on enwiki...

Details

	Subject	Repo	Branch	Lines +/-
	Size the Special:Nearby refresh icon correctly	mediawiki/extensions/MobileFrontend	wmf/1.26wmf9	+9 -2
	Size the Special:Nearby refresh icon correctly	mediawiki/extensions/MobileFrontend	master	+9 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		phuedx	T102215 Nearby refresh icon huge
		Resolved		phuedx	T102540 Notification count showing up on Nearby

Event Timeline

Jdlrobson created this task.Jun 12 2015, 3:30 AM

Jdlrobson raised the priority of this task from to High.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson moved this task to Incoming on the Web-Team-Backlog board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2015, 3:30 AM

Screen Shot 2015-06-12 at 9.16.22 AM.png (213×325 px, 15 KB)

Jdlrobson added a project: Mobile-Web-Sprint-49-Wayne's-World.Jun 12 2015, 4:14 PM

Jdlrobson set Security to None.

• KLans_WMF moved this task from Needs Analysis to To Do on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 12 2015, 5:43 PM

• KLans_WMF moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.

phuedx claimed this task.Jun 15 2015, 3:53 PM

phuedx moved this task from To Do to Doing on the Mobile-Web-Sprint-49-Wayne's-World board.

Change 218382 had a related patch set uploaded (by Phuedx):
Size the Special:Nearby refresh icon correctly

https://gerrit.wikimedia.org/r/218382

gerritbot added a project: Patch-For-Review.Jun 15 2015, 4:56 PM

phuedx moved this task from Doing to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 15 2015, 4:56 PM

Change 218382 merged by jenkins-bot:
Size the Special:Nearby refresh icon correctly

https://gerrit.wikimedia.org/r/218382

phuedx mentioned this in rMEXT78a6168859b8: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jun 15 2015, 5:01 PM

phuedx mentioned this in rEMFRd4bd3e722129: Size the Special:Nearby refresh icon correctly.

phuedx removed a project: Patch-For-Review.Jun 15 2015, 5:04 PM

phuedx moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-49-Wayne's-World board.

@Jdlrobson: Over to you for SWAT.

https://gerrit.wikimedia.org/r/218382 (branch master): WMF-deploy-2015-06-16_(1.26wmf10)

Still looks broken to me - now the Echo icon shows but is invisible..
Previously we didn't show Echo notifications on nearby - just the refresh icon.

Screen Shot 2015-06-15 at 11.13.32 AM.png (605×1 px, 91 KB)

(screenshot on beta labs)

Jdlrobson reassigned this task from Jdlrobson to phuedx.Jun 15 2015, 6:12 PM

Jdlrobson moved this task from Ready for Signoff to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.

Previously we didn't show Echo notifications on nearby - just the refresh icon.

That's another regression then? When did that creep in?

12:38 PM <jdlrobson> phuedx: should i still lightning deploy?
12:38 PM <phuedx|AFK> toodles for now y'all
12:38 PM <jdlrobson> given the bug is less obvious?
12:39 PM <phuedx|AFK> jdlrobson: the notifications alignment bug is being worked on by florian
12:39 PM <phuedx|AFK> the nearby icon is fixed afaict
12:39 PM <phuedx|AFK> that echo is being added to special:nearby? new regression! :/
12:39 PM <jdlrobson> yes so i'm wondering if i deploy knowing it is introducing a new less serious regression?
12:40 PM <phuedx|AFK> jdlrobson: it isn't, is it?
12:40 PM <jdlrobson> in stable notifications count is showing to left of nearby icon (previously we didn't show it)
12:41 PM <jdlrobson> it sounds like the answer is yes though to getting the nearby icon swat fixed :)
12:42 PM <phuedx|NAFK> jdlrobson: yeah -- i'm not sure what that's caused by but it sure ain't the nearby icon fix

Change 218519 had a related patch set uploaded (by Jdlrobson):
Size the Special:Nearby refresh icon correctly

https://gerrit.wikimedia.org/r/218519

gerritbot added a project: Patch-For-Review.Jun 15 2015, 9:11 PM

I couldn't get this SWATed today - no SWATers poked me or responded to my pokes on irc (I think there was some kind of https related issue) @phuedx could you try to get this SWAT deployed in the AM swat?

Jdlrobson reassigned this task from Jdlrobson to phuedx.Jun 16 2015, 12:22 AM

phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 16 2015, 9:36 AM

phuedx moved this task from Done to Ready for Signoff on the Mobile-Web-Sprint-49-Wayne's-World board.

T102540 tracks fixing the "notifications on Special:Nearby" bug.

phuedx closed this task as Resolved.Jun 16 2015, 10:47 AM

phuedx closed subtask T102540: Notification count showing up on Nearby as Resolved.

phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-49-Wayne's-World board.

phuedx removed a project: Patch-For-Review.Jun 16 2015, 11:39 AM

Change 218519 merged by Catrope:
Size the Special:Nearby refresh icon correctly

https://gerrit.wikimedia.org/r/218519

Jdlrobson mentioned this in rEMFRaf19283f9afb: Size the Special:Nearby refresh icon correctly.Jun 17 2015, 11:20 PM