Page MenuHomePhabricator
Create Task
Maniphest T102246

[Task] extensions may not use class_exists to check if an extension is loaded
Closed, InvalidPublic
Actions

Description

Extensions need to not use class_exists to check if an extension is loaded, at least for extension classes that can be autoloaded without the extension being enabled. This might happen for extensions that have an composer generated autoloader and are handled by the composer merge plugin.
A replacement might be ExtensionRegistry->isLoaded('name') if the extension was converted to use that.

Related Objects
Search...

StatusAssignedTask
 ResolvedAddshoreT173818 [Epic] Kill the Wikidata build step
 ResolvedAddshoreT181709 Cleanup Phabricator tickets once the build is dead
 InvalidNoneT108946 [Epic] Improve the development infrastructure
DeclinedNoneT95663 [Story] Use composer-merge-plugin to include Wikidata components in mediawiki-vendor
 InvalidNoneT102246 [Task] extensions may not use class_exists to check if an extension is loaded
 InvalidNoneT92980 [Story] Convert all extensions that are part of the Wikidata build to use the new extension registration
 OpenNoneT88258 Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration
 ResolvedVictorbarbuT119766 Composer's autoloader should be autoloaded in extension registry (if configured)
 ResolvedLucas_Werkmeister_WMDET223214 Start converting Wikibase extensions to use extension registration
 ResolvedMtDuT106104 [Task] Convert WikibaseQuality, WikibaseQualityConstraints and WikibaseQualityExternalValidation to use extension registration
 ResolvedLydia_PintscherT161716 Turn WikibaseQualityExternalValidation constants into config variables
 DeclinedLydia_PintscherT106635 Convert WikibaseQuery to use extension registration
 InvalidNoneT123026 change Wikidata build to load its included extensions via extension registration
 InvalidNoneT124054 [Task] Convert wikibase and data values libraries to use extension registration
 ResolvedReedyT124055 [Task] Convert PropertySuggester to use extension registration
 ResolvedLegoktmT168187 Convert Wikidata.org to use extension registration

Event Timeline

JanZerebecki created this task.Jun 12 2015, 3:39 PM
JanZerebecki raised the priority of this task from to Normal.
JanZerebecki updated the task description. (Show Details)
JanZerebecki added a project: Wikidata.
JanZerebecki added subscribers: JanZerebecki, Aklapper.
JanZerebecki renamed this task from extensions may not use class_exists to check if an extension is loaded to [Task] extensions may not use class_exists to check if an extension is loaded.Sep 10 2015, 8:45 PM
JanZerebecki moved this task from incoming to ready to go on the Wikidata board.
JanZerebecki set Security to None.
thiemowmde closed this task as Invalid.Sep 19 2017, 9:42 AM
thiemowmde added a subscriber: thiemowmde.

I'm going to close this ticket because it is – as it is now – not actionable. What this needs at least is a list of the specific extensions that need an update. What this tickets description suggests might still be done, but can be done any time with new, more specific tickets.

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptSep 19 2017, 9:42 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL