Page MenuHomePhabricator
Create Task
Maniphest T102246

[Task] extensions may not use class_exists to check if an extension is loaded
Closed, InvalidPublic
Actions

Description

Extensions need to not use class_exists to check if an extension is loaded, at least for extension classes that can be autoloaded without the extension being enabled. This might happen for extensions that have an composer generated autoloader and are handled by the composer merge plugin.
A replacement might be ExtensionRegistry->isLoaded('name') if the extension was converted to use that.

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedAddshoreT173818 [Epic] Kill the Wikidata build step
 ResolvedAddshoreT181709 Cleanup Phabricator tickets once the build is dead
 InvalidNoneT108946 [Epic] Improve the development infrastructure
DeclinedNoneT95663 [Story] Use composer-merge-plugin to include Wikidata components in mediawiki-vendor
 InvalidNoneT102246 [Task] extensions may not use class_exists to check if an extension is loaded
 InvalidNoneT92980 [Story] Convert all extensions that are part of the Wikidata build to use the new extension registration
 ResolvedNoneT88258 Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration
 ResolvedVictorbarbuT119766 Composer's autoloader should be autoloaded in extension registry (if configured)
 ResolvedLucas_Werkmeister_WMDET223214 Start converting Wikibase extensions to use extension registration
 ResolvedLadsgroupT256228 Convert WikibaseClient to use extension registration
 ResolvedLucas_Werkmeister_WMDET256238 Remove WB_VERSION, WBL_VERSION, WBC_VERSION constants
 DeclinedTarrowT256241 Check whether Client can load Lib without PHP entry point
 ResolvedLucas_Werkmeister_WMDET256243 Migrate Client API modules to extension JSON file
 ResolvedLucas_Werkmeister_WMDET256244 Migrate client $wgExtensionFunctions to extension JSON
 ResolvedLadsgroupT256245 Migrate Client i18n globals to extension JSON
 ResolvedNoneT256246 Migrate Client hooks to extension JSON
 ResolvedLadsgroupT256253 Stop registering some Client hooks only outside of unit tests
 ResolvedLucas_Werkmeister_WMDET256257 Migrate ClientHooks hook handlers to extension JSON
 ResolvedTarrowT256259 Migrate Client ChangesListLinesHandler hooks to extension JSON
 ResolvedLucas_Werkmeister_WMDET256260 Migrate Client SidebarHookHandlers hooks to extension JSON
 ResolvedLucas_Werkmeister_WMDET256261 Migrate Client MovePageNotice hook to extension JSON
 ResolvedLucas_Werkmeister_WMDET256262 Migrate Client InfoActionHookHandler hook to extension JSON
 ResolvedLucas_Werkmeister_WMDET256263 Migrate Client ParserLimitReportPrepareHookHandler hook to extension JSON
 ResolvedLucas_Werkmeister_WMDET256264 Migrate Client ParserClearStateHookHandler hook to extension JSON
 ResolvedLadsgroupT256265 Migrate Client EchoSetupHookHandlers hook to extension JSON
 ResolvedLadsgroupT256266 Migrate Client EchoNotificationsHandlers hook to extension JSON
 ResolvedLadsgroupT256267 Migrate Client DataUpdateHookHandlers hooks to extension JSON
 ResolvedLadsgroupT256268 Migrate Client UpdateRepoHookHandlers hooks to extension JSON
 ResolvedLadsgroupT256269 Migrate Client ChangesListSpecialPageHookHandlers hook to extension JSON
 ResolvedLadsgroupT256270 Migrate Client SqlUsageTrackerSchemaUpdater hook to extension JSON
 ResolvedLadsgroupT256271 Migrate Client DescriptionProviderHookHandler hook to extension JSON
 ResolvedLucas_Werkmeister_WMDET256764 Migrate Client ParserOutputUpdateHookHandlers hooks to extension JSON
 ResolvedLadsgroupT256247 Migrate Client job classes to extension JSON
 ResolvedItamarWMDET256248 Migrate Client $wgRecentChangesFlags to extension JSON
 ResolvedLucas_Werkmeister_WMDET256249 Migrate Client ResourceLoader modules (except Data Bridge) to extension JSON
 ResolvedLadsgroupT256250 Migrate Client Data Bridge ResourceLoader modules to extension JSON
 ResolvedItamarWMDET256251 Migrate Client special pages to extension JSON
 ResolvedLucas_Werkmeister_WMDET256252 Migrate wgWBClientDataTypes + wgWBClientSettings loading out of Client PHP entry point
 ResolvedLucas_Werkmeister_WMDET256756 Remove $wgWBRepoDataTypes and $wgWBClientDataTypes global variables
 ResolvedLadsgroupT257430 Copy Lib extension.json content to Client
 ResolvedLadsgroupT257431 Copy Lib extension.json content to Repo
 ResolvedLadsgroupT257432 Remove Lib extension.json
 ResolvedLadsgroupT257433 Convert Repo to use Extension Registration
 ResolvedLucas_Werkmeister_WMDET257441 Migrate Repo permissions to extension JSON file
 ResolvedLucas_Werkmeister_WMDET257442 Migrate Repo i18n globals to extension JSON file
 ResolvedLucas_Werkmeister_WMDET257443 Migrate Repo API modules to extension JSON file
 ResolvedLadsgroupT257444 Migrate Repo special pages to extension JSON file
 ResolvedNoneT257445 Migrate Repo hooks to extension JSON file
 ResolvedLadsgroupT257563 Migrate DatabaseSchemaUpdater hook handler to json
 ResolvedLadsgroupT257564 Migrate HtmlPageLinkRendererEndHookHandler to json
 ResolvedLadsgroupT257565 Migrate LabelPrefetchHookHandlers to json
 ResolvedTarrowT257566 Migrate ShowSearchHitHandler to json
 ResolvedItamarWMDET257567 Migrate OutputPageBeforeHTMLHookHandler to json
 ResolvedLadsgroupT257568 Migrate OutputPageJsConfigHookHandler to json
 ResolvedLadsgroupT257569 Migrate ArticleRevisionVisibilitySetHookHandler to json
 ResolvedItamarWMDET257570 Migrate ChangesSubscriptionSchemaUpdater to json
 ResolvedItamarWMDET257615 Migrate FederatedPropertiesSpecialPageHookHandler to json
 ResolvedLadsgroupT257446 Migrate Repo ResourceLoader modules to extension JSON file
 ResolvedLadsgroupT257447 Don’t load Repo settings in PHP entry point
 ResolvedLadsgroupT257448 Don’t define Repo content model constants in PHP entry point
 ResolvedLucas_Werkmeister_WMDET257449 Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack
 ResolvedLadsgroupT258043 Merge WikibaseView extension registeration into Repo
 ResolvedLadsgroupT257436 Deploy Repo using extension registration to Beta
 ResolvedMtDuT106104 [Task] Convert WikibaseQuality, WikibaseQualityConstraints and WikibaseQualityExternalValidation to use extension registration
 ResolvedLydia_PintscherT161716 Turn WikibaseQualityExternalValidation constants into config variables
 DeclinedLydia_PintscherT106635 Convert WikibaseQuery to use extension registration
 InvalidNoneT123026 change Wikidata build to load its included extensions via extension registration
 InvalidNoneT124054 [Task] Convert wikibase and data values libraries to use extension registration
 ResolvedReedyT124055 [Task] Convert PropertySuggester to use extension registration
 ResolvedLegoktmT168187 Convert Wikidata.org to use extension registration

Event Timeline

JanZerebecki created this task.Jun 12 2015, 3:39 PM
JanZerebecki raised the priority of this task from to Medium.
JanZerebecki updated the task description. (Show Details)
JanZerebecki added a project: Wikidata.
JanZerebecki added subscribers: JanZerebecki, Aklapper.
JanZerebecki renamed this task from extensions may not use class_exists to check if an extension is loaded to [Task] extensions may not use class_exists to check if an extension is loaded.Sep 10 2015, 8:45 PM
JanZerebecki moved this task from incoming to ready to go on the Wikidata board.
JanZerebecki set Security to None.
thiemowmde closed this task as Invalid.Sep 19 2017, 9:42 AM
thiemowmde added a subscriber: thiemowmde.

I'm going to close this ticket because it is – as it is now – not actionable. What this needs at least is a list of the specific extensions that need an update. What this tickets description suggests might still be done, but can be done any time with new, more specific tickets.

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptSep 19 2017, 9:42 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL