configs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	faidon
	Jun 15 2015, 2:44 PM

Description

While examining labstore1001, I've found that it is an unpuppetized mess, with lots of scripts and config files having edited/copied locally. What's even worse is that many of these have been copied to labstore1002(!), a fresh jessie installation, as well.

hese need to be fixed ASAP and never happen again, it's entirely unacceptable to have such config locally to the machine (and even more so, copied around to a second machine).

I've found at least the following:

/etc/exports.d/ROOT.exports & /etc/exports.d/PUBLIC.exports
/etc/default/nfs-kernel-server (the version is puppet does not match what's installed)
/etc/replication-rsync.conf
/usr/local/sbin/storage-replicate, /usr/local/sbin/storage-snapshot
/usr/local/sbin/manage-exports
/usr/local/sbin/manage-volumes-daemon (probably obsolete due to manage-nfs-volumes-daemon)?
/usr/local/sbin/projectbackup
/usr/local/sbin/migrate-to
a /root full of test scripts and test output

After this is done, I'd propose to cleanly reformat labstore1002 and do not apply anything manually before putting it in production, to make sure we haven't forgot anything on the old machine.

Details

Subject	Repo	Branch	Lines +/-
labstore: Add some package requirements for labstore*	operations/puppet	production	+4 -0
labstore: Move stuff into module from ldap module	operations/puppet	production	+22 -21
labstore: More puppetization fixes for labstore*	operations/puppet	production	+75 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	yuvipanda	T105720 Labs team reliability goal for Q1 2015/16
Resolved	coren	T102478 labstore has multiple unpuppetized files/scripts/configs
Resolved	coren	T107574 Reinstall labstore1001 and make sure everything is puppet-ready
Resolved	faidon	T107507 Investigate whether to use Debian's jessie-backports
Declined	faidon	T108941 Make certain that jessie-backports is disabled fleetwide.

Event Timeline

faidon created this task.Jun 15 2015, 2:44 PM

faidon assigned this task to coren.

faidon raised the priority of this task from to High.

faidon updated the task description. (Show Details)

faidon added projects: acl*sre-team, Cloud-Services.

faidon subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2015, 2:44 PM

coren added a project: Labs-Sprint-102.Jun 15 2015, 5:53 PM

Things that are known:

manage-volumes-daemon is old gluster code that probably did not have a ensure => absent

manage-snapshots
replication-rsync.conf
storage-replicate
storage-snapshots
are part of https://gerrit.wikimedia.org/r/#/c/199267/ , and deployed by hand for testing.

Known to need proper puppetization:
ROOT.exports
PUBLIC.exports

Needs investigation:
projectbackup
migrate-to

projectbackup and migrate-to were leftovers from the pmtpa migration and have been deleted, alongside the obsolete manage-volume-daemon.

coren moved this task from To Do to Doing on the Labs-Sprint-102 board.Jun 16 2015, 4:24 PM

Restricted Application added a subscriber: Matanya. · View Herald TranscriptJun 16 2015, 4:24 PM

Change 217861 had a related patch set uploaded (by coren):
Labs: Rewrite of manage-nfs-volumes-daemon

https://gerrit.wikimedia.org/r/217861

Change 218666 had a related patch set uploaded (by coren):
Labs: More puppetization fixes for labstore*

https://gerrit.wikimedia.org/r/218666

coren moved this task from Doing to Code Review / Blocked on the Labs-Sprint-102 board.Jun 16 2015, 5:45 PM

faidon added a project: Labs-Sprint-103.Jun 22 2015, 5:39 PM

faidon set Security to None.

coren moved this task from To Do to Doing on the Labs-Sprint-103 board.Jun 22 2015, 5:58 PM

coren moved this task from Doing to Code Review / Blocked on the Labs-Sprint-103 board.

yuvipanda added a project: Labs-Sprint-104.Jun 29 2015, 6:23 PM

Change 221864 had a related patch set uploaded (by Yuvipanda):
labstore: Move stuff into module from ldap module

https://gerrit.wikimedia.org/r/221864

Change 218666 merged by Yuvipanda:
labstore: More puppetization fixes for labstore*

https://gerrit.wikimedia.org/r/218666

yuvipanda mentioned this in rOPUPbba541fd2cb1: labstore: More puppetization fixes for labstore*.Jun 30 2015, 3:23 PM

Change 221864 merged by Yuvipanda:
labstore: Move stuff into module from ldap module

https://gerrit.wikimedia.org/r/221864

yuvipanda mentioned this in rOPUPb714ded29147: labstore: Move stuff into module from ldap module.Jun 30 2015, 3:28 PM

coren added a project: Labs-Sprint-105.Jul 8 2015, 1:49 PM

coren moved this task from To Do to Doing on the Labs-Sprint-105 board.Jul 10 2015, 2:37 PM

yuvipanda added a parent task: T105720: Labs team reliability goal for Q1 2015/16.Jul 22 2015, 9:07 AM

This should be done, or very near completion. As far as I can tell, there is no unpuppetized configuration but I'm not sure yet for packages.

coren added a project: Labs-Sprint-107.Jul 27 2015, 3:23 PM

coren moved this task from To Do to Doing on the Labs-Sprint-107 board.Jul 28 2015, 3:48 PM

Change 227710 had a related patch set uploaded (by coren):
Add some package requirements for labstore*

https://gerrit.wikimedia.org/r/227710

coren moved this task from Doing to Code Review / Blocked on the Labs-Sprint-107 board.Jul 29 2015, 2:35 PM

Change 227710 merged by coren:
labstore: Add some package requirements for labstore*

https://gerrit.wikimedia.org/r/227710

Anything else? /root still has test scripts, but that's presumably ok?

Sounds good to me, although I'd really prefer it if we reinstalled labstore1001 at this point before we switch over to it, to start from a clean slate and be absolutely sure that everything that needs to be there, is puppetized.

coren mentioned this in rOPUPb298a09ea258: labstore: Add some package requirements for labstore*.Jul 30 2015, 10:16 PM

In T102478#1494562, @faidon wrote:

Sounds good to me, although I'd really prefer it if we reinstalled labstore1001 at this point before we switch over to it, to start from a clean slate and be absolutely sure that everything that needs to be there, is puppetized.

Creating subticket for this then.

T107574 contains the remaining todo

coren moved this task from Code Review / Blocked to Done on the Labs-Sprint-107 board.Aug 3 2015, 5:39 PM

coren mentioned this in T88723: Fix documentation & puppetization for labs NFS.Sep 9 2015, 7:55 PM

coren closed subtask T107574: Reinstall labstore1001 and make sure everything is puppet-ready as Resolved.Oct 28 2015, 4:01 PM

• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:50 PM