Page MenuHomePhabricator
Create Task
Maniphest T102486

Search and replace button does not work on first click after closing the dialog with Esc or close button.
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  • Load a page with enabled CodeEditor.
  • Click on the Search and replace button. --> The dialog appears.
  • Press Esc on keyboard or click on the close button. --> The dialog disappears.
  • Click on the Search and Replace button again. --> Nothing happens.
  • Click on the Search and Replace button again. --> The dialog appears again.

Expected result:
The dialog should appear on the first click on the button.

Details

SubjectRepoBranchLines +/-
Repair search and replace buttonmediawiki/extensions/CodeEditormaster+3 -6
Improve accuracy of the search/replace togglemediawiki/extensions/CodeEditormaster+13 -14
Customize query in gerrit

Related Objects

Event Timeline

Fomafix created this task.Jun 15 2015, 3:30 PM
Fomafix raised the priority of this task from to Needs Triage.
Fomafix updated the task description. (Show Details)
Fomafix added a project: CodeEditor.
Fomafix subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2015, 3:30 PM
gerritbot subscribed.Jun 15 2015, 4:58 PM

Change 218385 had a related patch set uploaded (by Gerrit Patch Uploader):
Repair search button

https://gerrit.wikimedia.org/r/218385

gerritbot added a project: Patch-For-Review.Jun 15 2015, 4:58 PM
Fomafix claimed this task.Jun 17 2015, 4:27 AM
Fomafix triaged this task as Low priority.
Fomafix renamed this task from Search and replace button does not work on first click after closing the dialog with esc. to Search and replace button does not work on first click after closing the dialog with Esc or close button..Sep 15 2017, 5:26 AM
Fomafix updated the task description. (Show Details)
Nardog subscribed.Mar 17 2021, 12:07 PM
gerritbot added a comment.Mar 22 2021, 11:34 PM

Change 674164 had a related patch set uploaded (by Gerrit Patch Uploader; owner: Nardog):
[mediawiki/extensions/CodeEditor@master] Let search and replace button actually toggle the box

https://gerrit.wikimedia.org/r/674164

PatchDemoBot added a comment.Mar 27 2021, 10:02 AM

Test wiki created on Patch Demo by Nardog using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/18e359c978/w/

Nardog added a comment.Mar 27 2021, 10:03 AM
This comment was removed by Nardog.
PatchDemoBot added a comment.Mar 27 2021, 4:20 PM

Test wiki on Patch Demo by Nardog using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/18e359c978/w/

Nardog added a comment.Mar 27 2021, 4:24 PM

The above link was throwing errors, so I deleted the wiki and tried reinstalling it, but I can't recreate the demo for some reason...

PatchDemoBot added a comment.Mar 27 2021, 8:33 PM

Test wiki created on Patch Demo by Ed g2s using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/3db9ab883c/w/

Nardog added a project: Editing-team.Mar 31 2021, 1:18 PM
Nardog claimed this task.Mar 31 2021, 9:46 PM

Could someone please review the patch? I have patches for T146393 and T261118 but they kind of rely on this.

Izno subscribed.Jun 16 2021, 4:14 AM

(I am not the right person, to respond to the email poke.)

gerritbot added a comment.Jun 26 2021, 11:09 AM

Change 674164 merged by jenkins-bot:

[mediawiki/extensions/CodeEditor@master] Improve accuracy of the search/replace toggle

https://gerrit.wikimedia.org/r/674164

gerritbot added a comment.Jun 26 2021, 11:11 AM

Change 218385 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/CodeEditor@master] Repair search and replace button

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CodeEditor/ /674164

https://gerrit.wikimedia.org/r/218385

matmarex closed this task as Resolved.Jun 26 2021, 11:11 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 26 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 26 2021, 12:10 PM
PatchDemoBot added a comment.Sep 10 2021, 9:55 PM

Test wiki on Patch Demo by Ed g2s using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/3db9ab883c/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL