Page MenuHomePhabricator

Setting manifest_version should not explode in REL1_25
Closed, ResolvedPublic

Description

@ashley reported that using extension.json in 1.25 with manifest_version set results in:

[15-Jun-2015 19:18:02] PHP Warning:  array_merge_recursive() [<a href='function.array-merge-recursive'>function.array-merge-recursive</a>]: Argument #1 is not an array in D:\\xampp\\htdocs\\shoutwiki\\trunk\\includes\\registration\\ExtensionProcessor.php on line 294

We should make sure that manifest_version at the very least does not cause warnings in 1.25.

Event Timeline

Legoktm claimed this task.
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added subscribers: Legoktm, ashley.

To clarify, either extension.json or skin.json is fine for triggering this error. Furthermore, you need at least two (or more) skins/extensions loaded at the same time which have manifest_version set to trigger this error.

So this wouldn't trigger it:

wfLoadExtension( 'Bar' );

but this would:

wfLoadExtension( 'Bar' );
wfLoadExtension( 'Foo' );

Change 218787 had a related patch set uploaded (by Legoktm):
registration: Don't treat 'manifest_version' as an attribute

https://gerrit.wikimedia.org/r/218787

Change 218787 merged by Addshore:
registration: Don't treat 'manifest_version' as an attribute

https://gerrit.wikimedia.org/r/218787