Given I have a banner defined via a template on the page and I have not used the {{PAGEBANNER}} magic word then no default page banner should be shown. This will allow editors a clear path to redefine banners using the PageBanner extension.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
WikidataPageBanner prefix class names with wpb- | mediawiki/extensions/WikidataPageBanner | master | +13 -13 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Jdlrobson | T102537 Migrating existing templates to new PageBanner extension | |||
Resolved | Jdlrobson | T98029 Deploy PageBanner extension on English Wikivoyage project | |||
Resolved | None | T106586 Prefix all global variables | |||
Resolved | None | T107001 Invalid property name throws an error | |||
Resolved | Sumit | T106706 Drop use of OOUI\Theme::setSingleton() | |||
Resolved | Sumit | T106588 Module ext.WikidataPageBanner should depend on oojs-ui-styles not oojs-ui | |||
Resolved | • csteipp | T107231 Security review of Ex:PageBanner | |||
Resolved | None | T108788 Switch to turn default banners on/off added by WikidataPageBanner | |||
Resolved | Jdlrobson | T108839 Configuration changes for English Wikivoyage for WikidataPageBanner | |||
Resolved | Jdlrobson | T108614 Make sure WikidataPageBanner is adding image references to imagelinks table | |||
Open | None | T106772 test WikidataPageBanner its integration with Wikibase |
Event Timeline
This will be easily done by adding a config variable $wgShowDefaultBanner and adding a check for it where default banner is added. I'll add a patch this week.
Change 224089 had a related patch set uploaded (by Sumit):
WikidataPageBanner prefix class names with wpb-
It seems that migration is easier than thought, a simple modification of http://en.wikivoyage.org/wiki/Template:Pagebanner, to add a call to {{PAGEBANNER}} inside would do the trick. Since Template:Pagebanner is already used on English wikivoyage's pages, no modification of individual pages may be needed. See this example template http://pagebanner.wmflabs.org/wiki/Template:Pagebanner which uses the extension to render a banner on http://pagebanner.wmflabs.org/wiki/Canada
This just happened today. Yay!
https://en.wikivoyage.org/w/index.php?title=Template%3APagebanner&type=revision&diff=2846280&oldid=2810881