Page MenuHomePhabricator
Create Task
Maniphest T102540

Notification count showing up on Nearby
Closed, ResolvedPublic
Actions

Description

This didn't used to be the case.
When I inspect the DOM I see a div with class zero notification-count without the Echo icon

Previously the refresh icon replaced the notification count.

Screen Shot 2015-06-15 at 11.13.32 AM.png (605×1 px, 91 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove the notifications button properlymediawiki/extensions/MobileFrontendwmf/1.26wmf9+1 -1
Remove the notifications button properlymediawiki/extensions/MobileFrontendmaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedphuedxT102215 Nearby refresh icon huge
 ResolvedphuedxT102540 Notification count showing up on Nearby

Event Timeline

Jdlrobson created this task.Jun 15 2015, 7:52 PM
Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Mobile-Web-Sprint-49-Wayne's-World, Web-Team-Backlog-Archived.
Jdlrobson added subscribers: • Forrestbot, phuedx, gerritbot and 2 others.
phuedx added a comment.Jun 15 2015, 8:03 PM

This regression was introduced by 217068 according to git bisect.

gerritbot added a comment.Jun 15 2015, 8:49 PM

Change 218483 had a related patch set uploaded (by Phuedx):
Remove the notifications button properly

https://gerrit.wikimedia.org/r/218483

gerritbot added a project: Patch-For-Review.Jun 15 2015, 8:49 PM
phuedx moved this task from Needs Analysis to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 15 2015, 8:50 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 15 2015, 9:10 PM
gerritbot added a comment.Jun 15 2015, 9:15 PM

Change 218483 merged by jenkins-bot:
Remove the notifications button properly

https://gerrit.wikimedia.org/r/218483

Jdlrobson mentioned this in rEMFR8ef371ec3218: Remove the notifications button properly.Jun 15 2015, 9:15 PM
phuedx mentioned this in rMEXTe27449add561: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jun 15 2015, 9:15 PM
Jdlrobson moved this task from Ready for Signoff to -1 (Needs More Work) on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 15 2015, 9:49 PM
Jdlrobson moved this task from -1 (Needs More Work) to Ready for Signoff on the Mobile-Web-Sprint-49-Wayne's-World board.
• Forrestbot added a project: WMF-deploy-2015-06-16_(1.26wmf10).Jun 15 2015, 10:00 PM
phuedx claimed this task.Jun 16 2015, 9:57 AM
phuedx set Security to None.
phuedx mentioned this in T102215: Nearby refresh icon huge.
phuedx closed this task as Resolved.Jun 16 2015, 10:47 AM
phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-49-Wayne's-World board.
phuedx removed a project: Patch-For-Review.Jun 16 2015, 11:39 AM
gerritbot added a comment.Jun 17 2015, 11:15 PM

Change 219092 had a related patch set uploaded (by Jdlrobson):
Remove the notifications button properly

https://gerrit.wikimedia.org/r/219092

gerritbot added a project: Patch-For-Review.Jun 17 2015, 11:15 PM
gerritbot added a comment.Jun 17 2015, 11:20 PM

Change 219092 merged by Catrope:
Remove the notifications button properly

https://gerrit.wikimedia.org/r/219092

• Konfused-Kitten mentioned this in rEMFRfed64c0c0075: Remove the notifications button properly.Jun 17 2015, 11:20 PM
• Forrestbot added a project: WMF-deploy-2015-06-09_(1.26wmf9).Jun 18 2015, 12:01 AM
phuedx removed a project: Patch-For-Review.Jun 19 2015, 7:22 PM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
• Phabricator_maintenance moved this task from Incoming to 2014-15 Q4 on the Web-Team-Backlog-Archived board.Mar 7 2018, 1:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits