Page MenuHomePhabricator

Use the element identifiers from RESTBase instead of generating new identifiers and overwriting
Closed, ResolvedPublic1 Estimated Story Points

Description

RESTBase api (example https://simple.wikipedia.org/api/rest_v1/page/html/Oxygen ) started providing identifiers for HTML elements. CXServer now overwrite these identifiers by its own generated identifiers.

CXServer can just reuse the identifiers from RESTBase output. It also helps to restore a draft translation more accurately for a new revision of source.

Event Timeline

santhosh raised the priority of this task from to Medium.
santhosh updated the task description. (Show Details)

This looks great. Are the ids available on all pages already, or are there still cached pages without them?

Change 220441 had a related patch set uploaded (by Santhosh):
Reuse the element identifiers given by RESTBase

https://gerrit.wikimedia.org/r/220441

This looks great. Are the ids available on all pages already, or are there still cached pages without them?

We can fallback to id generation in such case. The client side also need to do this fallback because some of the drafts will be based on old source content. I am trying to make this change transparent to client side(drafts continue to work even if it was based on old source content with generated ids)

Change 220442 had a related patch set uploaded (by Santhosh):
[WIP] Changes to work with RESTBase ids for elements than CX generated ids

https://gerrit.wikimedia.org/r/220442

santhosh raised the priority of this task from Medium to High.Jul 21 2015, 9:06 PM
santhosh added a project: LE-CX6-Sprint 1.

@santhosh & @Nikerabbit, all content retrieved from RESTBase has ids assigned. We have stored data-parsoid separately from the start, which is keyed on those ids.

Change 220442 merged by jenkins-bot:
Use parsoid permanent ids for section instead of CX generated ids

https://gerrit.wikimedia.org/r/220442

Change 220441 merged by jenkins-bot:
Reuse the element identifiers given by RESTBase

https://gerrit.wikimedia.org/r/220441

Change 227942 had a related patch set uploaded (by KartikMistry):
Use parsoid permanent ids for section instead of CX generated ids

https://gerrit.wikimedia.org/r/227942

Change 227943 had a related patch set uploaded (by KartikMistry):
Use parsoid permanent ids for section instead of CX generated ids

https://gerrit.wikimedia.org/r/227943

Change 227942 abandoned by KartikMistry:
Use parsoid permanent ids for section instead of CX generated ids

https://gerrit.wikimedia.org/r/227942

Change 227943 abandoned by KartikMistry:
Use parsoid permanent ids for section instead of CX generated ids

https://gerrit.wikimedia.org/r/227943

Arrbee subscribed.