We could use a Jenkins job that runs PHP_CodeSniffer for the mediawiki/core master branch and make it voting.
phpcs is quite slow and goes beyond the composer 300 seconds timeout. We also need to raise the PHP memory limit which phpcs supports (phpcs -d option which conflicts with composer -d option). In the end the command should be:
time COMPOSER_PROCESS_TIMEOUT=600 PHPCS_ARGS="-v -d memory_limit=1G" composer phpcs .
timeout / memory limit subject to change.
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Replace mediawiki-core-phpcs-HEAD with mediawiki-core-phpcs | Legoktm | integration/config | master | +2 -6 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T102609 Make MediaWiki core pass mediawiki-codesniffer | |||
| Resolved | Legoktm | T102598 Craft a Jenkins job that runs PHP_CodeSniffer for mw/core using composer |
I think going through composer is going to be unnecessary overhead and make it more complicated. We can just call "vendor/bin/phpcs" directly..
Another thing to look into is having a job that only runs it against the files changed in the patchset for the "test" pipeline, and have the gate pipeline actually run the full phpcs.
Is there a reason to run it against the entire codebase at all? Wouldn't just running it against changed files suffice? (Once everything actually passes, that is.)
I took a stab at this today by creating a job that runs vendor/bin/phpcs -v --extensions=php,php5,inc,sample . except it doesn't work :(
https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/4/console
For some reason it's using the default PEAR sniffs instead of our phpcs.xml...
IIRC, it uses our phpcs.xml only if we don't specify any files to check. Try doing the same thing without specifying the . at the end.
ok, that was silly. It works now! https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/6/console
Change 241071 had a related patch set uploaded (by Legoktm):
Replace mediawiki-core-phpcs-HEAD with mediawiki-core-phpcs
Change 241071 merged by jenkins-bot:
Replace mediawiki-core-phpcs-HEAD with mediawiki-core-phpcs
Patches:
I didn't bother trying to create a job that only runs on changed files because right now the job takes 2-3 minutes, which is fast enough.
The average is currently around 3 minutes, but if it has to also clone MW core, it can hit 6 or 7 minutes.
Chart: https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs/buildTimeTrend