Page MenuHomePhabricator
Create Task
Maniphest T102609

Make MediaWiki core pass mediawiki-codesniffer
Closed, ResolvedPublic
Actions

Description

MediaWiki-Codesniffer (packagist, Gerrit) has improved considerably over the last few months and it's probably a good idea to make core pass the codesniffer tests.

  • Generic.CodeAnalysis.ForLoopWithTestFunctionCall.NotAllowed
  • Generic.Files.EndFileNewline.NotFound
  • Generic.Files.LineLength
  • Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
  • MediaWiki.NamingConventions.PrefixedGlobalFunctions.wfPrefix
  • MediaWiki.VariableAnalysis.UnusedGlobalVariables
  • MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect
  • MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceAfterOpenParenthesis
  • MediaWiki.WhiteSpace.SpaceyParenthesis.SingleSpaceBeforeCloseParenthesis
  • PSR2.Methods.MethodDeclaration.AbstractAfterVisibility
  • PSR2.Methods.MethodDeclaration.StaticBeforeVisibility
  • PSR2.Methods.MethodDeclaration.Underscore
  • PSR2.Namespaces.NamespaceDeclaration.BlankLineAfter
  • Squiz.Classes.ValidClassName.NotCamelCaps
  • Squiz.WhiteSpace.ScopeClosingBrace.Indent
  • Squiz.WhiteSpace.SemicolonSpacing.Incorrect
  • Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines

After this, T102598 could happen and we could have mediawiki-codesniffer running as a voting jenkins job against master.

The output of mediawiki codesniffer running against core (at 3247aa82027) can be found at P789.
The output against core (at 03c1d480a7d) and ignoring languages/messages and languages/classes can be found at P815.

You can try this out yourself by running:
phpcs --standard=vendor/mediawiki/mediawiki-codesniffer/MediaWiki --extensions=php,php5,inc --ignore=vendor,extensions -p .

Details

SubjectRepoBranchLines +/-
Re-enable last phpcs rulemediawiki/coremaster+1 -4
phpcs: Disable failing sniffs in phpcs.xmlmediawiki/coremaster+20 -1
Fixed spacingmediawiki/coremaster+76 -80
Customize query in gerrit

Related Objects
Search...

Event Timeline

polybuildr created this task.Jun 16 2015, 12:05 PM
polybuildr raised the priority of this task from to Needs Triage.
polybuildr updated the task description. (Show Details)
polybuildr added projects: MediaWiki-Codesniffer, MediaWiki-General.
polybuildr added subscribers: polybuildr, hashar, Legoktm, Addshore.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2015, 12:05 PM
polybuildr moved this task from Untriaged to Pass codesniffer on the MediaWiki-Codesniffer board.Jun 16 2015, 12:59 PM
polybuildr closed subtask T102619: Fix Generic.Files.EndFileNewline errors in MediaWiki core by ensuring files end with newline as Resolved.Jun 16 2015, 2:37 PM
Krenair subscribed.Jun 16 2015, 5:58 PM
Legoktm added a subtask: T102598: Craft a Jenkins job that runs PHP_CodeSniffer for mw/core using composer.Jun 16 2015, 7:44 PM
polybuildr closed subtask T102617: Fix MediaWiki.WhiteSpace.SpaceyParenthesis errors in MediaWiki core as Resolved.Jun 16 2015, 7:51 PM
hashar awarded a token.Jun 16 2015, 9:39 PM
polybuildr mentioned this in T102598: Craft a Jenkins job that runs PHP_CodeSniffer for mw/core using composer.Jun 17 2015, 11:53 AM
polybuildr closed subtask T102774: Fix Squiz.WhiteSpace.SuperfluousWhitespace errors in MediaWiki core as Resolved.Jun 17 2015, 1:48 PM
polybuildr closed subtask T102805: Fix braces issues in MediaWiki core code as Resolved.Jun 17 2015, 6:09 PM
gerritbot subscribed.Jun 17 2015, 8:22 PM

Change 219010 had a related patch set uploaded (by Umherirrender):
Fixed spacing

https://gerrit.wikimedia.org/r/219010

gerritbot added a project: Patch-For-Review.Jun 17 2015, 8:22 PM
gerritbot added a comment.Jun 17 2015, 8:50 PM

Change 219027 had a related patch set uploaded (by Paladox):
Fix phpcs warnings

https://gerrit.wikimedia.org/r/219027

gerritbot added a comment.Jun 17 2015, 9:40 PM

Change 219010 merged by jenkins-bot:
Fixed spacing

https://gerrit.wikimedia.org/r/219010

Umherirrender mentioned this in rMWd8821f2b0b40: Fixed spacing.Jun 17 2015, 9:40 PM
• Forrestbot added projects: WMF-deploy-2015-06-16_(1.26wmf10), MW-1.26-release.Jun 17 2015, 10:00 PM
• Forrestbot subscribed.
Nikerabbit reopened subtask T102805: Fix braces issues in MediaWiki core code as Open.Jun 18 2015, 6:46 AM
hashar unsubscribed.Jun 18 2015, 12:55 PM
Jdforrester-WMF closed subtask T102614: Fix Generic.Files.LineLength errors in MediaWiki core by breaking long lines as Resolved.Jun 18 2015, 8:22 PM
Umherirrender reopened subtask T102614: Fix Generic.Files.LineLength errors in MediaWiki core by breaking long lines as Open.Jun 18 2015, 8:33 PM
polybuildr updated the task description. (Show Details)Jun 20 2015, 8:35 PM
polybuildr set Security to None.
polybuildr removed projects: MW-1.26-release, WMF-deploy-2015-06-16_(1.26wmf10), Patch-For-Review.Jun 20 2015, 8:45 PM
Umherirrender subscribed.Jun 21 2015, 8:58 AM

--ignore=vendor,extensions,skins,languages/classes,languages/messages

languages/messages should only excluded from the long line check, the rest seems fine to check also in languages/classes

Umherirrender closed subtask T103243: Change spaces to tabs as Resolved.Jun 21 2015, 9:05 AM
polybuildr added a comment.Jun 21 2015, 9:07 AM

@Umherirrender, that is the plan. Since most of errors in the files in those directories are long line errors, I thought it would be a good idea to also show what the summary looks like without including that directory.

All other sniffs will certainly still run on those directories.

polybuildr closed subtask T102805: Fix braces issues in MediaWiki core code as Resolved.Jun 25 2015, 9:44 AM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
Umherirrender unsubscribed.Jul 5 2015, 7:23 PM
Addshore added a comment.Sep 7 2015, 11:16 AM

Any progress here / status update? :)

polybuildr added a comment.Sep 7 2015, 11:38 AM

@Addshore, still some way to go. A few tasks were resolved a while back, but then I got occupied with my GSoC project. After my midterms end (a few days from now), I'll investigate this is more depth.

polybuildr added a subtask: T112261: Fix issues identified by SpaceBeforeSingleLineComments sniff.Sep 11 2015, 1:20 PM
JanZerebecki subscribed.Sep 11 2015, 3:02 PM
Ricordisamoa awarded a token.Sep 23 2015, 10:07 PM
Ricordisamoa subscribed.
Legoktm closed subtask T102598: Craft a Jenkins job that runs PHP_CodeSniffer for mw/core using composer as Resolved.Sep 25 2015, 4:46 PM
Ricordisamoa merged a task: T113774: PHPCS errors in mediawiki.Sep 25 2015, 10:16 PM
Ricordisamoa added a subscriber: Paladox.
greg awarded a token.Sep 25 2015, 10:21 PM
greg subscribed.
Legoktm added a comment.Sep 26 2015, 5:04 AM

https://lists.wikimedia.org/pipermail/wikitech-l/2015-September/083383.html

Jdforrester-WMF subscribed.Sep 26 2015, 1:11 PM
gerritbot added a comment.Sep 26 2015, 1:27 PM

Change 241085 had a related patch set uploaded (by Jforrester):
Disable failing sniffs in phpcs.xml

https://gerrit.wikimedia.org/r/241085

gerritbot added a project: Patch-For-Review.Sep 26 2015, 1:27 PM
gerritbot added a comment.Sep 26 2015, 1:43 PM

Change 241085 merged by jenkins-bot:
phpcs: Disable failing sniffs in phpcs.xml

https://gerrit.wikimedia.org/r/241085

Jdforrester-WMF mentioned this in rMWa49a8e7f0969: phpcs: Disable failing sniffs in phpcs.xml.Sep 26 2015, 1:43 PM
Jdforrester-WMF removed a project: Patch-For-Review.Sep 26 2015, 1:49 PM
Jdforrester-WMF updated the task description. (Show Details)Sep 26 2015, 3:15 PM
Jdforrester-WMF updated the task description. (Show Details)Sep 26 2015, 3:17 PM
Jdforrester-WMF updated the task description. (Show Details)Sep 26 2015, 4:35 PM
Jdforrester-WMF updated the task description. (Show Details)Sep 26 2015, 4:46 PM
Jdforrester-WMF updated the task description. (Show Details)Sep 26 2015, 4:59 PM
Jdforrester-WMF updated the task description. (Show Details)Sep 26 2015, 5:14 PM
Reedy subscribed.Sep 26 2015, 6:16 PM

For some testing...

https://gerrit.wikimedia.org/r/#/c/241345/ is P2096

Reedy changed the status of subtask T113854: Fix Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed from Open to Stalled.Sep 26 2015, 8:10 PM
siebrand subscribed.Sep 27 2015, 5:32 AM
• Purodha subscribed.Sep 27 2015, 7:11 AM
ReleaseTaggerBot added projects: MW-1.27-release, MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 9:24 PM
greg edited projects, added MW-1.27-release-notes; removed MW-1.27-release.Sep 29 2015, 10:28 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:49 AM
Umherirrender closed subtask T113854: Fix Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed as Resolved.Oct 3 2015, 6:39 PM
Umherirrender closed subtask T104501: Fix global variable and function prefixes in core as Resolved.Oct 3 2015, 7:15 PM
Amire80 closed subtask T102614: Fix Generic.Files.LineLength errors in MediaWiki core by breaking long lines as Resolved.Oct 6 2015, 1:23 PM
Amire80 closed subtask T102614: Fix Generic.Files.LineLength errors in MediaWiki core by breaking long lines as Resolved.
Umherirrender closed subtask T112261: Fix issues identified by SpaceBeforeSingleLineComments sniff as Resolved.Oct 14 2015, 4:55 PM
gerritbot added a comment.Oct 14 2015, 5:08 PM

Change 241345 had a related patch set uploaded (by Umherirrender):
Re-enable last phpcs rule

https://gerrit.wikimedia.org/r/241345

gerritbot added a project: Patch-For-Review.Oct 14 2015, 5:08 PM
Umherirrender closed this task as Resolved.Oct 14 2015, 5:12 PM
Umherirrender removed projects: MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)), MW-1.27-release-notes.
Umherirrender subscribed.

All issues in the current configuration are fixed and that means phpcs is passing mediawiki/core at the moment.

gerritbot added a comment.Oct 14 2015, 5:23 PM

Change 241345 merged by jenkins-bot:
Re-enable last phpcs rule

https://gerrit.wikimedia.org/r/241345

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)), MW-1.27-release-notes.Oct 14 2015, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL