Page MenuHomePhabricator

Fix MediaWiki.WhiteSpace.SpaceyParenthesis errors in MediaWiki core
Closed, ResolvedPublic

Description

  1. No space between function name and opening brace: wfFoo() good, wfFoo () bad
  2. Single space after opening parenthesis and before closing parenthesis: wfFoo( $bar ) good, wfFoo($bar) bad, wfFoo( $bar ) bad (note extra space)
  3. No space if no arguments: wfFoo() good, wfFoo( ) bad

Sniff output: P791

Summary:

..W...W..........W..W..................W....................   60 / 1909 (3%)
............................................................  120 / 1909 (6%)
............................................................  180 / 1909 (9%)
............................................................  240 / 1909 (13%)
............................................................  300 / 1909 (16%)
............................................................  360 / 1909 (19%)
.....................W.....W................................  420 / 1909 (22%)
................................W...........................  480 / 1909 (25%)
......................W.....................................  540 / 1909 (28%)
............................................................  600 / 1909 (31%)
..................W.........................................  660 / 1909 (35%)
W...................................W....W....WW...W........  720 / 1909 (38%)
...................W....W............W............W...W.....  780 / 1909 (41%)
................W.....................W......W..............  840 / 1909 (44%)
..................W.........................................  900 / 1909 (47%)
W..W................W...............................W.......  960 / 1909 (50%)
......W...W............W.................................... 1020 / 1909 (53%)
........................S................................... 1080 / 1909 (57%)
............W...................................W........... 1140 / 1909 (60%)
..............................................W............. 1200 / 1909 (63%)
............................................................ 1260 / 1909 (66%)
.............W..............W.................W............. 1320 / 1909 (69%)
............................................................ 1380 / 1909 (72%)
.....W..............................................W....... 1440 / 1909 (75%)
...W..........W............................................. 1500 / 1909 (79%)
.................W...........................W.............. 1560 / 1909 (82%)
............................................................ 1620 / 1909 (85%)
.................................................W.........W 1680 / 1909 (88%)
.......W.............W................W...............W.W... 1740 / 1909 (91%)
........................W..SS................S.............. 1800 / 1909 (94%)
.............................S........................W..... 1860 / 1909 (97%)
................W................................

Event Timeline

polybuildr raised the priority of this task from to Needs Triage.
polybuildr updated the task description. (Show Details)
polybuildr added subscribers: Addshore, Legoktm, hashar and 2 others.

Change 218695 had a related patch set uploaded (by Polybuildr):
Fix whitespace issues around parentheses

https://gerrit.wikimedia.org/r/218695

Change 218695 merged by jenkins-bot:
Fix whitespace issues around parentheses

https://gerrit.wikimedia.org/r/218695

polybuildr closed this task as Resolved.Jun 16 2015, 7:51 PM
polybuildr set Security to None.
hashar removed a subscriber: hashar.Jun 23 2015, 12:29 PM