Page MenuHomePhabricator

"MobileFrontend modules/mf-translator - Check click on a language link" test broken, causing Thanks failures
Closed, ResolvedPublic

Description

Example: https://integration.wikimedia.org/ci/job/mwext-Thanks-qunit-mobile/84/console

18:54:17 >> MobileFrontend modules/mf-translator - Check click on a language link
18:54:17 >> Message: Saved click on 'de' language link
18:54:17 >> Actual: 2
18:54:17 >> Expected: 1
18:54:17 >> at http://localhost:9412/jenkins-mwext-Thanks-qunit-mobile-84/load.php?debug=false&lang=en&modules=jquery.qunit%7Cjquery.qunit.completenessTest&skin=minerva&version=4797304160c0&*:20
18:54:17 >>   at http://localhost:9412/jenkins-mwext-Thanks-qunit-mobile-84/load.php?debug=false&lang=en&modules=ext.eventLogging%7Cext.thanks.mobilediff%7Cjquery.byteLength%2CcheckboxShiftClick%2Ccookie%2CgetAttrs%2CmakeCollapsible%2Cmw-jump%2Cplaceholder%2Cthrottle-debounce%7Cmediawiki.Title%2Capi%2CconfirmCloseWindow%2Ccookie%2Cuser%7Cmediawiki.page.ready%7Cmediawiki.ui.anchor%7Cmobile.abusefilter%2Cajax%2CbannerImage%2Cdrawers%2Cexperiments%2CforeignApi%2Cgallery%2Chexmd5%2CinfiniteScroll%2Cinfobox%2Cissues%2Clanguages%2CloggingSchemas%2CmediaViewer%2CmessageBox%2CmicroAutoSize%2Cnearby%2Coverlays%2Cpagelist%2CpreferredLanguages%2Creferences%2Csearch%2Csettings%2Cstartup%2Ctoast%2Ctoggling%2Cuser%2Cwatchlist%2Cwatchstar%7Cmobile.bannerImage.tests%7Cmobile.browser.tests%7Cmobile.editor.api%2Ccommon%2Coverlay%7Cmobile.editor.api.tests%7Cmobile.editor.overlay.tests%7Cmobile.experiments.tests%7Cmobile.gallery.tests%7Cmobile.infiniteScroll.tests%7Cmobile.infobox.tests%7Cmobile.issues.tests%7Cmobile.languages.tests%7Cmobile.mediaViewer.tests%7Cmobile.modules.tests%7Cmobile.nearby.tests%7Cmobile.oo.tests%7Cmobile.overlays.tests%7Cmobile.pagelist.scripts%2Cstyles%7Cmobile.pagelist.scripts.tests%7Cmobile.pagesummary.styles%7Cmobile.preferredLanguages.tests%7Cmobile.references.tests%7Cmobile.search.tests%7Cmobile.special.mobilediff.scripts%7Cmobile.special.nearby.styles%7Cmobile.startup.tests%7Cmobile.talk.overlays%7Cmobile.talk.overlays.tests%7Cmobile.toggling.tests%7Cmobile.user.tests%7Cmobile.view.tests%7Cmobile.watchlist.tests%7Cmobile.watchstar.tests%7Cmobile.wikidata.api%7Coojs-ui%7Coojs-ui.styles%7Coojs-ui.styles.icons%2Cindicators%2Ctextures%7Cschema.MobileWebBrowse%2CMobileWebDiffClickTracking%2CMobileWebEditing%2CMobileWebMainMenuClickTracking%2CMobileWebSearch%2CMobileWebUIClickTracking%2CMobileWebUploads%2CMobileWebWatching%2CMobileWebWatchlistClickTracking%7Cskins.minerva.icons.images.legacy%7Ctest.mediawiki.qunit.testrunner%7Ctest.sinonjs%7Ctests.ext.thanks.mobilediff%7Ctests.mobile.templates&skin=minerva&version=ecb8e2ed505a&*:259
18:54:17 >>   at http://localhost:9412/jenkins-mwext-Thanks-qunit-mobile-84/load.php?debug=false&lang=en&modules=jquery.qunit%7Cjquery.qunit.completenessTest&skin=minerva&version=4797304160c0&*:13
18:54:17 >>   at http://localhost:9412/jenkins-mwext-Thanks-qunit-mobile-84/load.php?debug=false&lang=en&modules=jquery.qunit%7Cjquery.qunit.completenessTest&skin=minerva&version=4797304160c0&*:16
18:54:17 >>   at process (http://localhost:9412/jenkins-mwext-Thanks-qunit-mobile-84/load.php?debug=false&lang=en&modules=jquery.qunit%7Cjquery.qunit.completenessTest&skin=minerva&version=4797304160c0&*:9)
18:54:17 >>   at begin (http://localhost:9412/jenkins-mwext-Thanks-qunit-mobile-84/load.php?debug=false&lang=en&modules=jquery.qunit%7Cjquery.qunit.completenessTest&skin=minerva&version=4797304160c0&*:9)
18:54:17 >>   at http://localhost:9412/jenkins-mwext-Thanks-qunit-mobile-84/load.php?debug=false&lang=en&modules=jquery.qunit%7Cjquery.qunit.completenessTest&skin=minerva&version=4797304160c0&*:9

Details

Event Timeline

Legoktm raised the priority of this task from to High.
Legoktm updated the task description. (Show Details)
Legoktm added projects: MobileFrontend, Thanks.
Legoktm subscribed.

Yeh we've seen this on a few other commits. Not sure of cause yet but if someone merges https://phabricator.wikimedia.org/T99814 this test disappears and this should fix itself.

Change 219048 had a related patch set uploaded (by Jdlrobson):
Remove troublesome test

https://gerrit.wikimedia.org/r/219048

Change 219048 abandoned by Jdlrobson:
Remove troublesome test

Reason:
No longer necessary

https://gerrit.wikimedia.org/r/219048

phuedx claimed this task.
phuedx subscribed.

Closing this as Resolved as the test was removed as part of the work for T99814. It's a shame that we couldn't share more light on the problem, but there you have it.

If you think there is value we can replicate it using grunt on that patchset or using Special:JavaScript/qunit/plain

See also https://phabricator.wikimedia.org/T101795

I don't have an opinion, just happy that Thanks is unblocked. Thanks! ;-)