Maniphest T102719

Error in PageActionOverlay
Closed, ResolvedPublic
Actions

Description

Uncaught TypeError: Cannot read property 'on' of undefined
ContentOverlay.extend.addPointerArrow @ PageActionOverlay.js:91

this.options.skin.on( 'changed', $.proxy( this, 'refreshPointerArrow', this.options.target ) );

Details

	Subject	Repo	Branch	Lines +/-
	Pass skin to PageActionsOverlay.	mediawiki/extensions/Gather	wmf/1.26wmf10	+3 -1
	Pass skin to PageActionsOverlay.	mediawiki/extensions/Gather	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned In: rEGAT7eb36feffb4d: Pass skin to PageActionsOverlay.
rMWcf480e4235cd: Updated mediawiki/core Project: mediawiki/extensions/Gather…
rMEXT663b65e84717: Updated mediawiki/extensions Project: mediawiki/extensions/Gather…
rEGAT2320d22be5ae: Pass skin to PageActionsOverlay.

Event Timeline

• bmansurov created this task.Jun 16 2015, 11:14 PM

• bmansurov raised the priority of this task from to Needs Triage.

• bmansurov updated the task description. (Show Details)

• bmansurov added a project: Web-Team-Backlog.

• bmansurov subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2015, 11:14 PM

Change 218785 had a related patch set uploaded (by Bmansurov):
Pass skin to PageActionsOverlay.

https://gerrit.wikimedia.org/r/218785

gerritbot added a project: Patch-For-Review.Jun 16 2015, 11:20 PM

• bmansurov added projects: Mobile-Web-Sprint-49-Wayne's-World, Gather.Jun 16 2015, 11:20 PM

• bmansurov set Security to None.

• bmansurov moved this task from Needs Analysis to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.

phuedx subscribed.Jun 17 2015, 3:33 PM

Change 218785 merged by jenkins-bot:
Pass skin to PageActionsOverlay.

https://gerrit.wikimedia.org/r/218785

Change 218927 had a related patch set uploaded (by Phuedx):
Pass skin to PageActionsOverlay.

https://gerrit.wikimedia.org/r/218927

@Jdlrobson: I've cherry picked 218785 to wmf/1.26wmf10 since the bug that this fixes is visible on test.m.wikipedia.org.

https://gerrit.wikimedia.org/r/218785 (branch master): WMF-deploy-2015-06-16_(1.26wmf10)

phuedx moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.Jun 17 2015, 4:22 PM

• bmansurov mentioned this in rMEXT663b65e84717: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jun 17 2015, 4:24 PM

• bmansurov mentioned this in rEGAT2320d22be5ae: Pass skin to PageActionsOverlay..

Jdlrobson moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-49-Wayne's-World board.Jun 17 2015, 4:32 PM

Jdlrobson moved this task from Needs triage to This Sprint on the Gather board.Jun 17 2015, 5:16 PM

Change 218927 merged by Catrope:
Pass skin to PageActionsOverlay.

https://gerrit.wikimedia.org/r/218927

• bmansurov mentioned this in rMWcf480e4235cd: Updated mediawiki/core Project: mediawiki/extensions/Gather….Jun 17 2015, 11:27 PM

phuedx mentioned this in rEGAT7eb36feffb4d: Pass skin to PageActionsOverlay..Jun 17 2015, 11:28 PM

Deployed. Looks good to me.

phuedx removed a project: Patch-For-Review.Jun 19 2015, 7:22 PM

Jdforrester-WMF added a project: WMF-deploy-2015-06-23_(1.26wmf11).Jun 22 2015, 9:16 PM

Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM

• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:24 AM