Page MenuHomePhabricator

Error in PageActionOverlay
Closed, ResolvedPublic

Description

Uncaught TypeError: Cannot read property 'on' of undefined
ContentOverlay.extend.addPointerArrow @ PageActionOverlay.js:91

this.options.skin.on( 'changed', $.proxy( this, 'refreshPointerArrow', this.options.target ) );

Event Timeline

bmansurov raised the priority of this task from to Needs Triage.
bmansurov updated the task description. (Show Details)
bmansurov added a project: Readers-Web-Backlog.
bmansurov added a subscriber: bmansurov.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2015, 11:14 PM

Change 218785 had a related patch set uploaded (by Bmansurov):
Pass skin to PageActionsOverlay.

https://gerrit.wikimedia.org/r/218785

phuedx added a subscriber: phuedx.Jun 17 2015, 3:33 PM

Change 218785 merged by jenkins-bot:
Pass skin to PageActionsOverlay.

https://gerrit.wikimedia.org/r/218785

Change 218927 had a related patch set uploaded (by Phuedx):
Pass skin to PageActionsOverlay.

https://gerrit.wikimedia.org/r/218927

@Jdlrobson: I've cherry picked 218785 to wmf/1.26wmf10 since the bug that this fixes is visible on test.m.wikipedia.org.

Jdlrobson moved this task from Needs triage to This Sprint on the Gather board.Jun 17 2015, 5:16 PM

Change 218927 merged by Catrope:
Pass skin to PageActionsOverlay.

https://gerrit.wikimedia.org/r/218927

Jdlrobson closed this task as Resolved.Jun 17 2015, 11:29 PM
Jdlrobson claimed this task.

Deployed. Looks good to me.