Page MenuHomePhabricator
Create Task
Maniphest T102735

Page.content_model returns None pre 1.21
Closed, DeclinedPublic
Actions

Description

Page.content_model was only implemented for 1.21+, using the API result.
.css and .js pages, typically used in MediaWiki: and User: namespaces, could return a different content_model pre 1.21

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[IMPR] rewrite Revision classpywikibot/coremaster+233 -203
Customize query in gerrit

Related Objects

Event Timeline

jayvdb created this task.Jun 17 2015, 2:48 AM
jayvdb raised the priority of this task from to Needs Triage.
jayvdb updated the task description. (Show Details)
jayvdb added a project: Pywikibot.
jayvdb subscribed.
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJun 17 2015, 2:48 AM
jayvdb moved this task from Backlog to Backwards compatibility on the Pywikibot board.Jun 17 2015, 2:49 AM
Mpaa subscribed.Oct 11 2015, 8:16 PM

Wasn't contentmodel introduced in 1.22 for 'info' and in 1.21 for 'revisions'?
Is it returned in some other way?

Legoktm subscribed.Oct 11 2015, 8:29 PM

ContentHandler did not exist prior to 1.21...

Mpaa added a comment.Oct 11 2015, 8:35 PM

I miss what this means then:
".css and .js pages, typically used in MediaWiki: and User: namespaces, could return a different content_model pre 1.21"

jayvdb added a comment.Oct 11 2015, 11:45 PM
In T102735#1718458, @Mpaa wrote:

I miss what this means then:
".css and .js pages, typically used in MediaWiki: and User: namespaces, could return a different content_model pre 1.21"

I was hoping that we could detect that Page( enwp, 'User:Foo/common.js' ) on pre 1.21 is 'javascript' instead of 'wikitext'.

gerritbot subscribed.Mar 6 2017, 3:57 PM

Change 291605 had a related patch set uploaded (by xqt):
[pywikibot/core] [IMPR] rewrite Revision class

https://gerrit.wikimedia.org/r/291605

gerritbot added a project: Patch-For-Review.Mar 6 2017, 3:57 PM
gerritbot added a comment.Mar 6 2017, 4:00 PM

Change 341342 had a related patch set uploaded (by xqt):
[pywikibot/core] [IMPR] rewrite Revision class

https://gerrit.wikimedia.org/r/341342

Xqt claimed this task.Mar 6 2017, 4:26 PM
Xqt triaged this task as Medium priority.Mar 31 2017, 5:42 AM
Framawiki subscribed.Jun 18 2018, 8:19 PM
Aklapper added a comment.Mar 1 2020, 6:13 AM

@Xqt: Hi! This task has been assigned to you a while ago, and related patches have not seen updates recently. Do you still plan to work on this task? Thanks!

Xqt added a comment.Aug 2 2020, 5:00 PM
In T102735#5930173, @Aklapper wrote:

@Xqt: Hi! This task has been assigned to you a while ago, and related patches have not seen updates recently. Do you still plan to work on this task? Thanks!

Yes, I do. See related patch.

gerritbot added a comment.Nov 2 2020, 7:38 PM

Change 341342 merged by jenkins-bot:
[pywikibot/core@master] [IMPR] rewrite Revision class

https://gerrit.wikimedia.org/r/341342

Xqt mentioned this in rPWBC43dca2afc8a2: [IMPR] rewrite Revision class.Nov 2 2020, 7:39 PM
Xqt closed this task as Declined.Jan 23 2021, 3:26 PM

MW < 1.23 will be desupported

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits