Page MenuHomePhabricator

Error in WikibaseClientTest::testGetLangLinkHandlerReturnType if the current site is not in the sites table.
Closed, ResolvedPublic1 Estimated Story Points

Description

Hi another user tested using this patch https://gerrit.wikimedia.org/r/#/c/216630/ but is getting this error

14:35:16 There was 1 error:
14:35:16
14:35:16 1) Wikibase\Client\Tests\WikibaseClientTest::testGetLangLinkHandlerReturnType
14:35:16 Cannot find site jenkins_u3_mw in sites table [Called from Wikibase\Client\WikibaseClient::newSiteGroup in /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/Wikibase/client/includes/WikibaseClient.php at line 443]
14:35:16
14:35:16 /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/includes/debug/MWDebug.php:300
14:35:16 /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/includes/debug/MWDebug.php:155
14:35:16 /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/includes/GlobalFunctions.php:1201
14:35:16 /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/Wikibase/client/includes/WikibaseClient.php:443
14:35:16 /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/Wikibase/client/includes/WikibaseClient.php:461
14:35:16 /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/Wikibase/client/includes/WikibaseClient.php:422
14:35:16 /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/Wikibase/client/includes/WikibaseClient.php:553
14:35:16 /mnt/jenkins-workspace/workspace/mwext-Wikidata-testextension-zend/src/extensions/Wikidata/extensions/Wikibase/client/tests/phpunit/includes/WikibaseClientTest.php:79

Please see test run at https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension-zend/347/console

Event Timeline

Paladox raised the priority of this task from to Needs Triage.
Paladox updated the task description. (Show Details)
Paladox added a project: Wikidata.
Paladox added subscribers: Paladox, JanZerebecki.
JanZerebecki set Security to None.
JanZerebecki added a subscriber: daniel.

This https://git.wikimedia.org/commitdiff/mediawiki%2Fextensions%2FWikibase/6bce53f323b771fdc2783ccaf1c9bb06a68e9cbd

introduces

public function testGetLangLinkHandlerReturnType() {

in test file so that is why it is causing error it is to do witht hat patch.

Change 219042 had a related patch set uploaded (by Paladox):
Missing use statement

https://gerrit.wikimedia.org/r/219042

Change 219042 abandoned by Paladox:
Missing use statement

https://gerrit.wikimedia.org/r/219042

Change 219625 had a related patch set uploaded (by Hoo man):
Make WikibaseClientTest::testGetLangLinkHandlerReturnType more robust

https://gerrit.wikimedia.org/r/219625

hoo renamed this task from Error in wikidata test if scribunto and cldr enabled to Error in WikibaseClientTest::testGetLangLinkHandlerReturnType if the current site is not in the sites table..Jun 21 2015, 3:37 PM
hoo claimed this task.
hoo triaged this task as Medium priority.

Change 219625 merged by jenkins-bot:
Make WikibaseClientTest::testGetLangLinkHandlerReturnType more robust

https://gerrit.wikimedia.org/r/219625

Change 220945 had a related patch set uploaded (by Hoo man):
Make WikibaseClientTest::testGetLangLinkHandlerReturnType more robust

https://gerrit.wikimedia.org/r/220945

Change 220945 merged by jenkins-bot:
Make WikibaseClientTest::testGetLangLinkHandlerReturnType more robust

https://gerrit.wikimedia.org/r/220945