https://phabricator.wikimedia.org/F180359
each time I type a character in the editing window on commons :(
Description
Description
Details
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/core | wmf/1.26wmf10 | +17 -11 | Revert "StashEdit: Use postWithToken" | |
| mediawiki/core | master | +17 -11 | Revert "StashEdit: Use postWithToken" |
Related Objects
Related Objects
Event Timeline
Comment Actions
this is especially a problem if I backspace/delete some characters (e.g. the date) and then start typing another date.
here i am just doing cut & paste of a template, replacing the description and date.
Comment Actions
Caused by https://gerrit.wikimedia.org/r/#/c/217293/ . The reason the code did not use api.postWithToken is that that returns a promise, which is not abortable.
Comment Actions
Change 219005 had a related patch set uploaded (by Alex Monk):
Revert "StashEdit: Use postWithToken"
Comment Actions
Change 219007 had a related patch set uploaded (by Ori.livneh):
Revert "StashEdit: Use postWithToken"
Comment Actions
While promises do not have to be abortable, it would be technically possible to extend the promise returned api.postWithToken() with an .abort() function.
66d568958317b could have documented (comment in code) the fact @ori mentioned.
Comment Actions
Grrrr, my bad. I had a local followup for this module, that rewrote it to use jquery.throttle-debounce (so did not need abort). Probably should have squashed that into a single change, instead of trying to split it up.
BTW: Please do mention or subscribe authors and reviewers of original changes. This totally went unnoticed for me, if it were not for the fact that i happened to go through my list of recently closed changes for totally unrelated reasons.
CC. @Legoktm
Comment Actions
Gerrit is supposed to send you a notification for the revert comment on https://gerrit.wikimedia.org/r/#/c/217293/
Comment Actions
Yeah, but that goes into a high signal to noise ratio mailbox, where if i didn't mark all previous emails as read, it's very easy to miss.. A new phab ticket is much more noticeable (because it starts a new email thread).