Page MenuHomePhabricator

Big logout icon
Closed, ResolvedPublic

Description


Another unintentional side effect of our main menu developments?

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2015, 7:57 PM
Jdlrobson triaged this task as High priority.Jun 17 2015, 8:04 PM

(In stable)

Seems to have been caused by Ic49206ec463b72b7c0285a84849ac0f5e08dbdf6
I think this patch was merged a bit hastily and I'm concerned it might be impacted other parts of the ui.
Ping @Florian and @Esanders

Ping @phuedx - I'm not sure whether we should revert this change or provide a fix up:
https://gerrit.wikimedia.org/r/#/c/218608/
(see T86366)

Introducing view-border-box class on the left menu should fix this particular case. I'll prepare a patch in case that's what you want to do. I think this is the only case where I can see breakage.

Change 219266 had a related patch set uploaded (by Jdlrobson):
Correct icon sizes in left menu

https://gerrit.wikimedia.org/r/219266

Change 219266 merged by jenkins-bot:
Correct icon sizes in left menu

https://gerrit.wikimedia.org/r/219266

Florian closed this task as Resolved.Jun 19 2015, 10:40 AM
Florian claimed this task.

sorry, haven't seen this :(

Florian reassigned this task from Florian to Jdlrobson.Jun 19 2015, 10:40 AM
Florian set Security to None.

@Jdlrobson: Given the impact of the issue and that the bug is in production, I think your fix was appropriate.

@Florian: It's okay. Things will always slip by. Moving forward I think we might try getting at least two reviewers for that kind of patch – y'know, the "small but affects everything" patch – as it'll improve the chances of this type of bug being caught.

As always, thanks for doing what you do!