Another unintentional side effect of our main menu developments?
Description
Another unintentional side effect of our main menu developments?
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Correct icon sizes in left menu | mediawiki/extensions/MobileFrontend | master | +3 -1 |
Related Objects
- Mentioned In
- rMEXTa621968027eb: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFR61bc5cb3b81d: Correct icon sizes in left menu
T86366: Revisit box-sizing: border-box for everything in MobileFrontend - Mentioned Here
- T86366: Revisit box-sizing: border-box for everything in MobileFrontend
Event Timeline
Ping @phuedx - I'm not sure whether we should revert this change or provide a fix up:
https://gerrit.wikimedia.org/r/#/c/218608/
(see T86366)
Introducing view-border-box class on the left menu should fix this particular case. I'll prepare a patch in case that's what you want to do. I think this is the only case where I can see breakage.
Change 219266 had a related patch set uploaded (by Jdlrobson):
Correct icon sizes in left menu
@Jdlrobson: Given the impact of the issue and that the bug is in production, I think your fix was appropriate.
@Florian: It's okay. Things will always slip by. Moving forward I think we might try getting at least two reviewers for that kind of patch – y'know, the "small but affects everything" patch – as it'll improve the chances of this type of bug being caught.
As always, thanks for doing what you do!