Page MenuHomePhabricator

Settings link has disappeared from left menu
Closed, ResolvedPublic

Description

Not seeing it in stable or beta....

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 18 2015, 12:06 AM

Ping @phuedx. Browser tests will not be happy.

phuedx added a comment.EditedJun 18 2015, 5:32 AM

I see the link locally and on enwiki in stable and on beta. I don't see it on testwiki. I can't currently get a response from the beta cluster (but I'm assuming that's where you're looking).

Ping @phuedx. Browser tests will not be happy.

Users won't be happy, right?

Jdlrobson added a comment.EditedJun 18 2015, 1:22 PM

Your logic is true.
If browser tests are not happy => users will not be happy.

I suspect mustache templating is also to blame for this.

The "settings" entry isn't present in wgMFMenuData when the page is rendered on testwiki so something's removing it prior to first render. Is anything other than Gather listening to the MinervaDiscoveryTools event?

WikiGrok and Gather are in the only ones that should be messy with this data.

Jdlrobson triaged this task as High priority.Jun 18 2015, 6:42 PM

I assume this is high priority so I'll take a look

Am able to replicate it on the Barry browser bot instance. Disabling Gather does seem to fix it. Debugging some more.

Okay patch incoming

Change 219230 had a related patch set uploaded (by Jdlrobson):
Correctly insert collections into the main menu

https://gerrit.wikimedia.org/r/219230

Jdlrobson moved this task from Doing to Code Review on the Mobile-Web-Sprint-49-Wayne's-World board.

Change 219230 merged by jenkins-bot:
Correctly insert collections into the main menu

https://gerrit.wikimedia.org/r/219230

This is on English Wikipedia now and collections link no longer showing there.

@phuedx can you swat Friday?

@Jdlrobson: No. We don't – and mustn't – SWAT on a Friday. This'll have to wait until Monday, which is frustrating I know, but it is what it is.

phuedx closed this task as Resolved.Jun 19 2015, 3:23 PM

Verified locally. This ain't on BC yet though…

In testing this I found out why I didn't notice this before: I've still got wgMFPhotoUploadEndpoint enabled, which meant that the Gather hook was stripping out the Upload entry rather than the Settings entry.

Hooks are an abomination. We should generate the main menu without them :-/
We should help @Florian move https://gerrit.wikimedia.org/r/#/c/209820/ along.

This wasn't strictly the fault of the hook. It's that the menu is configured in such a way that makes it hard to modify the way we want. With that in mind, we should definitely help @Florian move his patch along!

Change 219880 had a related patch set uploaded (by Jdlrobson):
Correctly insert collections into the main menu

https://gerrit.wikimedia.org/r/219880

Change 219880 merged by jenkins-bot:
Correctly insert collections into the main menu

https://gerrit.wikimedia.org/r/219880