Not seeing it in stable or beta....
Description
Details
Related Objects
- Mentioned In
- rEGAT55f0494b2dc0: Correctly insert collections into the main menu
rMW00b200462b10: Updated mediawiki/core Project: mediawiki/extensions/Gather…
rEGAT168b95cf8e70: Correctly insert collections into the main menu
rMEXT864f052d89c8: Updated mediawiki/extensions Project: mediawiki/extensions/Gather…
Event Timeline
I see the link locally and on enwiki in stable and on beta. I don't see it on testwiki. I can't currently get a response from the beta cluster (but I'm assuming that's where you're looking).
Your logic is true.
If browser tests are not happy => users will not be happy.
I suspect mustache templating is also to blame for this.
The "settings" entry isn't present in wgMFMenuData when the page is rendered on testwiki so something's removing it prior to first render. Is anything other than Gather listening to the MinervaDiscoveryTools event?
Am able to replicate it on the Barry browser bot instance. Disabling Gather does seem to fix it. Debugging some more.
Change 219230 had a related patch set uploaded (by Jdlrobson):
Correctly insert collections into the main menu
This is on English Wikipedia now and collections link no longer showing there.
@phuedx can you swat Friday?
@Jdlrobson: No. We don't – and mustn't – SWAT on a Friday. This'll have to wait until Monday, which is frustrating I know, but it is what it is.
Verified locally. This ain't on BC yet though…
In testing this I found out why I didn't notice this before: I've still got wgMFPhotoUploadEndpoint enabled, which meant that the Gather hook was stripping out the Upload entry rather than the Settings entry.
Hooks are an abomination. We should generate the main menu without them :-/
We should help @Florian move https://gerrit.wikimedia.org/r/#/c/209820/ along.
This wasn't strictly the fault of the hook. It's that the menu is configured in such a way that makes it hard to modify the way we want. With that in mind, we should definitely help @Florian move his patch along!
Change 219880 had a related patch set uploaded (by Jdlrobson):
Correctly insert collections into the main menu
- https://gerrit.wikimedia.org/r/219880 (branch wmf/1.26wmf10): WMF-deploy-2015-06-16_(1.26wmf10)