Page MenuHomePhabricator

Make article lead image in native card view scrollable to see all images
Closed, ResolvedPublic3 Estimated Story Points

Description

Embed the gallery as the "lead image" of the article view controller

  • User should be able to swipe to see all images without launching full screen gallery view
  • Images should be aspect fill
  • Tapping on the image launches the full screen gallery view
  • Gallery in preview header should not show image meta data

QA Notes

  • Full regression on gallery rotation handling, both in preview and full screen (resize to fit, handles zoom correctly).
  • Loading indicators now display while image and/or article is loading:
    • Set network link conditioner to 3G
    • Search for something
    • Tap a result you know will eventually have a lead image
    • Tap the area where preview would show the lead image
    • Gallery should show w/ a loading indicator
    • Loading indicator disappears after image finishes loading
    • Swiping left/right to images should show loading indicator if the image hasn't been viewed in the gallery before
  • Verify preview header gallery is scrollable
    • Search for something w/ many images and tap on it (e.g. Claude Monet)
    • The search result (and native preview) should show the lead image
    • After tapping the result, you should eventually be able to scroll to the rest of the image in the page
    • Tapping on one of those images should show the fullscreen gallery, which will show a loading indicator until the high-res version is downloaded (if there is one)
  • Current image should be synchronized between preview gallery & fullscreen gallery
    • Swipe a few times past the lead image in the preview gallery, then tap on it
    • The same image should be displayed in the fullscreen gallery
    • Swipe to another image in the fullscreen gallery
    • Dismiss the gallery
    • The last viewed image in the fullscreen gallery should be displayed in the preview gallery.
  • Proper LTR & RTL handling of preview & fullscreen galleries

Event Timeline

Fjalapeno raised the priority of this task from to Needs Triage.
Fjalapeno updated the task description. (Show Details)
Fjalapeno subscribed.
KLans_WMF renamed this task from Embed gallery view controller in top Article View Controller to Make article lead image in native card view scrollable.EditedJun 19 2015, 6:26 PM
KLans_WMF renamed this task from Make article lead image in native card view scrollable to Make article lead image in native card view scrollable to see all images.

Note: @Fjalapeno need to talk to @Vibhabamba about captions for next iteration

Change 225245 had a related patch set uploaded (by Bgerstle):
make images scrollable in article header

https://gerrit.wikimedia.org/r/225245

Change 225245 merged by jenkins-bot:
make images scrollable in article header

https://gerrit.wikimedia.org/r/225245