The infinite scrolling in user collections doesn't work (after the templates kerfluffle has been solved) and it also doesn't work on the new /all/active.
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Fix collections list pagination | mediawiki/extensions/Gather | master | +83 -23 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Jdlrobson | T101115 Anon users can access public view from main menu | |||
Resolved | Jdlrobson | T101201 Notification for hamburger and tipsy in menu to call out collections | |||
Resolved | Jdlrobson | T96222 Add a new public collection feed view | |||
Resolved | Jdlrobson | T102188 Add 'Active' and 'My collections' tabs to tab between active and my collections | |||
Resolved | • Jhernandez | T102983 Infinite scrolling on collections list broken (user collections vs active collections) |
Event Timeline
Comment Actions
@Jdlrobson @phuedx please do not promote the Collections tabs change without resolving this.
Let's not push a broken change to prod.
Comment Actions
Change 219233 had a related patch set uploaded (by Jhernandez):
WIP: Fix collections pagination
Comment Actions
Jhernandez: Fix collections list pagination [extensions/Gather] - https://gerrit.wikimedia.org/r/219233 (https://phabricator.wikimedia.org/T102983)
Ready for review.
Comment Actions
@Jdlrobson Addressed issues, agreed that this could do some tests, not sure in what form though. So just hold on to merging if you prefer to wait for the tests, but review the change to know that it's good :D Thanks for the comments
Comment Actions
Verified on BC as part of T103496. The API call doesn't for logged out users but the infinite scrolling does work generally.