Page MenuHomePhabricator

Infinite scrolling on collections list broken (user collections vs active collections)
Closed, ResolvedPublic

Description

The infinite scrolling in user collections doesn't work (after the templates kerfluffle has been solved) and it also doesn't work on the new /all/active.

Event Timeline

Jhernandez updated the task description. (Show Details)
Jhernandez raised the priority of this task from to High.
Jhernandez claimed this task.
Jhernandez moved this task to To Do on the Mobile-Web-Sprint-49-Wayne's-World board.
Jhernandez added subscribers: Jhernandez, Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 18 2015, 5:55 PM
Jhernandez added a subscriber: phuedx.

@Jdlrobson @phuedx please do not promote the Collections tabs change without resolving this.

Let's not push a broken change to prod.

Change 219233 had a related patch set uploaded (by Jhernandez):
WIP: Fix collections pagination

https://gerrit.wikimedia.org/r/219233

Jhernandez: Fix collections list pagination [extensions/Gather] - https://gerrit.wikimedia.org/r/219233 (https://phabricator.wikimedia.org/T102983)

Ready for review.

@Jdlrobson Addressed issues, agreed that this could do some tests, not sure in what form though. So just hold on to merging if you prefer to wait for the tests, but review the change to know that it's good :D Thanks for the comments

Change 219233 merged by jenkins-bot:
Fix collections list pagination

https://gerrit.wikimedia.org/r/219233

Verified on BC as part of T103496. The API call doesn't for logged out users but the infinite scrolling does work generally.

phuedx closed this task as Resolved.Jun 25 2015, 1:37 PM
phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-49-Wayne's-World board.