Note the excessive whitespace.
We should get rid of the left margin to remove the gap.
Jdlrobson | |
Jun 18 2015, 10:09 PM |
F183578: Screen Shot 2015-06-25 at 1.14.07 PM.png | |
Jun 25 2015, 8:12 PM |
F180837: Screen Shot 2015-06-18 at 3.11.40 PM.png | |
Jun 18 2015, 10:09 PM |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | • rmoen | T101344 [EPIC] Push max-width and last modified work for mobile on desktop to stable | |||
Resolved | Jdlrobson | T103024 Excessive margin in notifications overlay on tablets |
https://gerrit.wikimedia.org/r/#/c/219989/
Sorry can't tag it right now as on mobile device and gerrit is not mobile friendly
Change 219989 had a related patch set uploaded (by Phuedx):
Fix the positioning of overlay headings
@bmansurov was concerned about a style regression but I honestly can't see it and am not sure we should block on it:
http://i.imgur.com/90zzOzW.png => http://i.imgur.com/dnVcnlI.png
It's not only a minor styling issue, it's also about doing the right thing. You're basically ignoring "maxwidth - 2*paddings" and displaying content differently.
To quote @Jdlrobson yourself:
When focusing search or editor, the close icon should match up with the content area and the hamburger icon. [1]
You've written this patch to fix the spacing issue, but ignoring the new spacing issue.
Change 221090 had a related patch set uploaded (by Bmansurov):
Remove wikitext editor padding in alpha and beta.
Change 221090 merged by jenkins-bot:
Fix the positioning of overlay headings and content