Page MenuHomePhabricator
Create Task
Maniphest T103024

Excessive margin in notifications overlay on tablets
Closed, ResolvedPublic
Actions

Description

Screen Shot 2015-06-18 at 3.11.40 PM.png (545×497 px, 30 KB)

Note the excessive whitespace.
We should get rid of the left margin to remove the gap.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+32 -24Fix the positioning of overlay headings
mediawiki/extensions/MobileFrontendmaster+20 -1Fix the positioning of overlay headings and content
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jun 18 2015, 10:09 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Roadmap, Notice, Mobile-Web-Sprint-49-Wayne's-World, Readers-Web-Backlog.
Jdlrobson added subscribers: phuedx, • JKatzWMF, dr0ptp4kt and 3 others.
phuedx removed projects: Notice, Roadmap.Jun 19 2015, 10:02 AM
phuedx set Security to None.
phuedx moved this task from Incoming to Old Unorganized Resolved Tasks on the Readers-Web-Backlog board.Jun 19 2015, 2:30 PM
• KLans_WMF added a project: Reading-Web-Sprint-50-The-X-Files.Jun 22 2015, 4:25 PM
Jdlrobson updated the task description. (Show Details)Jun 22 2015, 4:30 PM
• KLans_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-50-The-X-Files board.Jun 22 2015, 4:31 PM
Jdlrobson claimed this task.Jun 22 2015, 7:52 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-50-The-X-Files board.
Jdlrobson removed a project: Mobile-Web-Sprint-49-Wayne's-World.
Jdlrobson moved this task from Doing to -1 (Needs More Work) on the Reading-Web-Sprint-50-The-X-Files board.Jun 22 2015, 9:27 PM

I've been poking at this a bit. Not too happy with any of the solutions so far :-/

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jun 24 2015, 10:58 PM
phuedx added a comment.Jun 25 2015, 3:42 PM

Where's the patch for this?

dr0ptp4kt removed a subscriber: dr0ptp4kt.Jun 25 2015, 3:43 PM
Jdlrobson added a comment.Jun 25 2015, 5:28 PM

https://gerrit.wikimedia.org/r/#/c/219989/
Sorry can't tag it right now as on mobile device and gerrit is not mobile friendly

gerritbot added a subscriber: gerritbot.Jun 25 2015, 5:39 PM

Change 219989 had a related patch set uploaded (by Phuedx):
Fix the positioning of overlay headings

https://gerrit.wikimedia.org/r/219989

gerritbot added a project: Patch-For-Review.Jun 25 2015, 5:39 PM
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-50-The-X-Files board.Jun 25 2015, 7:20 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jun 25 2015, 8:11 PM

Talk looks fine to me in stable and beta - the close icon and content are aligned:

Screen Shot 2015-06-25 at 1.14.07 PM.png (420×929 px, 21 KB)

Jdlrobson added a subscriber: bmansurov.Jun 25 2015, 11:47 PM

@bmansurov was concerned about a style regression but I honestly can't see it and am not sure we should block on it:
http://i.imgur.com/90zzOzW.png => http://i.imgur.com/dnVcnlI.png

bmansurov added a comment.EditedJun 26 2015, 10:24 AM

It's not only a minor styling issue, it's also about doing the right thing. You're basically ignoring "maxwidth - 2*paddings" and displaying content differently.

To quote @Jdlrobson yourself:

When focusing search or editor, the close icon should match up with the content area and the hamburger icon. [1]

You've written this patch to fix the spacing issue, but ignoring the new spacing issue.

[1] https://gerrit.wikimedia.org/r/#/c/219989/

gerritbot added a comment.Jun 26 2015, 10:31 AM

Change 221090 had a related patch set uploaded (by Bmansurov):
Remove wikitext editor padding in alpha and beta.

https://gerrit.wikimedia.org/r/221090

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-50-The-X-Files board.Jun 29 2015, 4:40 PM
gerritbot added a comment.Jul 1 2015, 10:18 PM

Change 221090 merged by jenkins-bot:
Fix the positioning of overlay headings and content

https://gerrit.wikimedia.org/r/221090

Jdlrobson mentioned this in rEMFR2690e1e02e33: Fix the positioning of overlay headings and content.Jul 1 2015, 10:18 PM
Jdlrobson moved this task from -1 (Needs More Work) to Ready for Signoff on the Reading-Web-Sprint-50-The-X-Files board.Jul 1 2015, 10:18 PM
Diffusion mentioned this in rMEXT3e691a5f25a3: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jul 1 2015, 10:18 PM
Forrestbot added a project: WMF-deploy-2015-07-07_(1.26wmf13).Jul 1 2015, 11:00 PM
Jhernandez removed a project: Readers-Web-Backlog.Jul 2 2015, 9:51 AM
phuedx closed this task as Resolved.Jul 3 2015, 12:26 PM

Verified on BC.

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-50-The-X-Files board.Jul 3 2015, 12:26 PM
gerritbot added a comment.Jul 3 2015, 6:09 PM

Change 219989 abandoned by Jdlrobson:
Fix the positioning of overlay headings

https://gerrit.wikimedia.org/r/219989

phuedx removed a project: Patch-For-Review.Jul 6 2015, 6:49 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL