Maniphest T103027

QUnit should bypass target mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 18 2015, 10:20 PM

Tags

Referenced Files

None

Subscribers

Description

That way we can kill the custom mobile qunit job and use the same as everyone else.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	SpecialJavaScriptTest: Bypass ResourceLoader 'target' scope	mediawiki/core	master	+5 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T103027 QUnit should bypass target mode
		Resolved		Jdlrobson	T104361 Allow mobile tests to run outside mobile alpha mode
		Resolved		Jdlrobson	T104362 Certain tests failing in bypassed target mode
		Resolved		Jdlrobson	T106622 test_SearchOverlay.js should not use mw.loader.using or M.on
		Resolved		Jdlrobson	T106623 Problems with Browser memoisation tests
		Resolved		Sn1per	T106628 InfiniteScroll and api qunit tests are being skipped.
		Resolved		Jdlrobson	T107122 VisualEditor tests fail in target agnostic mode
		Resolved		phuedx	T106759 22:37:23 ERROR: '[GatherClicks] Missing or empty schema' in qunit tests
		Resolved		Jdlrobson	T107357 ULS tests fail in bypassed target mode

Event Timeline

Jdlrobson created this task.Jun 18 2015, 10:20 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog-Archived.

Jdlrobson moved this task to 2016-17 Q2 on the Web-Team-Backlog-Archived board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 18 2015, 10:20 PM

Jdlrobson moved this task from 2016-17 Q2 to Triaged but Future on the Web-Team-Backlog-Archived board.Jun 18 2015, 10:20 PM

Change 216886 had a related patch set uploaded (by Jdlrobson):
SpecialJavaScriptTest: Bypass ResourceLoader 'target' scope

https://gerrit.wikimedia.org/r/216886

gerritbot added a project: Patch-For-Review.Jun 18 2015, 10:21 PM

Not 100% sure what's going on in https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/1592/consoleFull @Krinkle and how this environment differs from the one we are currently running... I think T101795 will make these green though..

Jdlrobson mentioned this in T99877: MobileFrontend qunit tests should run Gather tests as well.Jun 18 2015, 10:22 PM

Jdlrobson added a subtask: T101795: Do not pull initialisation scripts along with JavaScript modules.Jun 25 2015, 9:54 PM

Jdlrobson removed a subtask: T101795: Do not pull initialisation scripts along with JavaScript modules.Jun 30 2015, 6:13 PM

phuedx closed subtask T104361: Allow mobile tests to run outside mobile alpha mode as Resolved.Jul 7 2015, 3:44 PM

Jdlrobson mentioned this in T106622: test_SearchOverlay.js should not use mw.loader.using or M.on.Jul 24 2015, 11:49 PM

For completeness the following patches when merged should make this mergeable:
https://gerrit.wikimedia.org/r/226435
https://gerrit.wikimedia.org/r/226448
https://gerrit.wikimedia.org/r/226437
https://gerrit.wikimedia.org/r/226942
https://gerrit.wikimedia.org/r/226940

Jdlrobson claimed this task.Jul 24 2015, 11:53 PM

Jdlrobson reassigned this task from Jdlrobson to Krinkle.

Jdlrobson set Security to None.

Jdlrobson mentioned this in T104362: Certain tests failing in bypassed target mode.Jul 28 2015, 9:01 PM

Krinkle triaged this task as Medium priority.Jul 29 2015, 11:02 PM

Krinkle added a project: MediaWiki-Core-Tests.

Change 216886 merged by jenkins-bot:
SpecialJavaScriptTest: Bypass ResourceLoader 'target' scope

https://gerrit.wikimedia.org/r/216886

Jdlrobson mentioned this in rMWe9b9e4df7a53: SpecialJavaScriptTest: Bypass ResourceLoader 'target' scope.Aug 4 2015, 10:23 PM

• Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-08-11_(1.26wmf18).Aug 4 2015, 11:00 PM

Krinkle closed this task as Resolved.Aug 5 2015, 6:39 PM

Jdlrobson closed subtask T104362: Certain tests failing in bypassed target mode as Resolved.Aug 6 2015, 8:16 PM

• Phabricator_maintenance moved this task from Triaged but Future to 2015-16 Q1 on the Web-Team-Backlog-Archived board.Mar 7 2018, 1:11 AM