Page MenuHomePhabricator
Create Task
Maniphest T103044

[Bug] Interwiki links for newly created wikis are shown at the bottom of sidebar
Closed, ResolvedPublic
Actions

Description

Interwiki links for newly created wikis are shown at the bottom of sidebar.

Example: https://en.wikipedia.org/wiki/Category:Poland

Details

SubjectRepoBranchLines +/-
Strict code order in InterwikiSortermediawiki/extensions/Wikibasemaster+9 -1
Partly revert "alphabetic" InterwikiSorter ordermediawiki/extensions/Wikibasemaster+47 -24
Tests for more edge cases in InterwikiSortermediawiki/extensions/Wikibasemaster+17 -2
Sort order alphabetically unknown languagemediawiki/extensions/Wikibasemaster+4 -4
Add 'azb'mediawiki/extensions/Wikibasewmf/1.26wmf13+4 -4
Add 'azb'mediawiki/extensions/Wikibasemaster+4 -4
Add lrc and gommediawiki/extensions/Wikibasemaster+48 -47
Customize query in gerrit

Related Objects

Event Timeline

Mjbmr created this task.Jun 19 2015, 2:17 AM
Mjbmr assigned this task to Krenair.
Mjbmr raised the priority of this task from to Unbreak Now!.
Mjbmr updated the task description. (Show Details)
Mjbmr added projects: Wikidata, MediaWiki-extensions-WikibaseClient.
Mjbmr subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2015, 2:17 AM
Lydia_Pintscher added subscribers: Lydia_Pintscher, aude, hoo.Jun 19 2015, 10:39 AM
Restricted Application removed a subscriber: Mjbmr. · View Herald TranscriptJun 19 2015, 10:39 AM
Lydia_Pintscher lowered the priority of this task from Unbreak Now! to High.Jun 19 2015, 10:40 AM
Lydia_Pintscher moved this task from incoming to needs discussion or investigation on the Wikidata board.Jun 19 2015, 1:16 PM
gerritbot subscribed.Jun 19 2015, 6:11 PM

Change 219411 had a related patch set uploaded (by Mjbmr):
Add lrc and gom

https://gerrit.wikimedia.org/r/219411

gerritbot added a project: Patch-For-Review.Jun 19 2015, 6:11 PM
Mjbmr subscribed.Jun 19 2015, 11:38 PM

gomwiki: T96468
lrcwiki: T102026

gerritbot added a comment.Jun 20 2015, 1:48 PM

Change 219411 merged by jenkins-bot:
Add lrc and gom

https://gerrit.wikimedia.org/r/219411

Diffusion mentioned this in rMEXTb0b4691da7c1: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jun 20 2015, 1:48 PM
Mjbmr mentioned this in rEWBA880bb8d4873b: Add lrc and gom.Jun 20 2015, 1:48 PM
Lydia_Pintscher added a comment.Jun 26 2015, 11:19 AM

Does this patch fix it or is there more to do? If there is more please remove patch-for-review.

Krenair removed Krenair as the assignee of this task.Jun 26 2015, 11:39 AM
Krenair subscribed.

That'd fix it for the newest Wikipedias. Don't know if we should come up with a way that can easily be fixed inside mediawiki-config by the new wiki deployer.

Lydia_Pintscher removed a project: Patch-For-Review.Jun 26 2015, 11:53 AM
Lydia_Pintscher set Security to None.

@aude: What do you say? Important enough to put time into?

aude added a comment.Jun 26 2015, 1:00 PM

@Lydia_Pintscher it is terrible that we have code for sorting links in Wikibase, when it is something generic. I would like to solve this more general issue and have a more sane place to put this stuff. (and that would make it easier when there is a new wikipedia) I am sure we have a ticket for the general issue.

the sorting order used to be maintained on meta wiki for pywikibot, so someone would have needed to add it there in the past and was not something deployers dealt with.

hoo added a comment.Jun 26 2015, 2:38 PM

We could just make it a setting and set it in mediawiki-config, I guess

gerritbot added a comment.Jun 26 2015, 2:42 PM

Change 221124 had a related patch set uploaded (by Mjbmr):
Sort order alphabetically unknown language

https://gerrit.wikimedia.org/r/221124

gerritbot added a project: Patch-For-Review.Jun 26 2015, 2:42 PM
Lydia_Pintscher added a comment.Jun 26 2015, 2:46 PM

@aude: Ok. Makes sense.

gerritbot added a comment.Jul 19 2015, 10:59 PM

Change 225834 had a related patch set uploaded (by Mjbmr):
Add 'azb'

https://gerrit.wikimedia.org/r/225834

gerritbot added a comment.Jul 23 2015, 1:52 AM

Change 226460 had a related patch set uploaded (by Mjbmr):
Add 'azb'

https://gerrit.wikimedia.org/r/226460

gerritbot added a comment.Jul 23 2015, 1:59 PM

Change 225834 merged by jenkins-bot:
Add 'azb'

https://gerrit.wikimedia.org/r/225834

Addshore mentioned this in rEWBA13571671a20e: Add 'azb'.Jul 23 2015, 1:59 PM
Mjbmr mentioned this in rMEXT21cb44e8665d: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 23 2015, 2:00 PM
gerritbot added a comment.Jul 23 2015, 2:13 PM

Change 226460 merged by jenkins-bot:
Add 'azb'

https://gerrit.wikimedia.org/r/226460

Mjbmr mentioned this in rEWBA2498f76188fe: Add 'azb'.Jul 23 2015, 2:14 PM
Glaisher merged a task: T104175: "Languages" list in sidebar (interwiki) shows some newly added wikis at the end of the list instead of alphabetic order.Jul 23 2015, 4:30 PM
Glaisher added a project: Wikimedia-Interwiki-links.
Glaisher added subscribers: Glaisher, Hugo.arg.
gerritbot added a comment.Aug 21 2015, 2:54 PM

Change 232939 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Tests for more edge cases in InterwikiSorter

https://gerrit.wikimedia.org/r/232939

gerritbot added a comment.Aug 21 2015, 3:00 PM

Change 221124 merged by jenkins-bot:
Sort order alphabetically unknown language

https://gerrit.wikimedia.org/r/221124

Diffusion mentioned this in rMEXT5569c203a1b5: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 21 2015, 3:00 PM
Mjbmr mentioned this in rEWBAf87d18b63df3: Sort order alphabetically unknown language.Aug 21 2015, 3:00 PM
thiemowmde added a project: Wikidata-Sprint-2015-08-18.Aug 21 2015, 3:14 PM
thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2015-08-18 board.
thiemowmde subscribed.
Lydia_Pintscher moved this task from needs discussion or investigation to in progress on the Wikidata board.Aug 22 2015, 8:55 AM
Lydia_Pintscher renamed this task from Interwiki links for newly created wikis are shown at the bottom of sidebar to [Bug] Interwiki links for newly created wikis are shown at the bottom of sidebar.Aug 22 2015, 10:25 AM
gerritbot added a comment.Aug 25 2015, 3:17 PM

Change 232939 merged by jenkins-bot:
Tests for more edge cases in InterwikiSorter

https://gerrit.wikimedia.org/r/232939

thiemowmde mentioned this in rEWBAed29afbc3889: Tests for more edge cases in InterwikiSorter.Aug 25 2015, 3:17 PM
thiemowmde mentioned this in rMEXT2a052a725d68: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….
gerritbot added a comment.Aug 27 2015, 3:56 PM

Change 234298 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Partly revert "alphabetic" InterwikiSorter order

https://gerrit.wikimedia.org/r/234298

gerritbot added a comment.Aug 28 2015, 9:23 AM

Change 234298 merged by jenkins-bot:
Partly revert "alphabetic" InterwikiSorter order

https://gerrit.wikimedia.org/r/234298

Addshore mentioned this in rEWBAbfd1f0d174c5: Partly revert "alphabetic" InterwikiSorter order.Aug 28 2015, 9:23 AM
thiemowmde mentioned this in rMEXTd6df67316098: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 28 2015, 9:23 AM
mxn subscribed.Aug 30 2015, 9:04 PM
In T103044#1404692, @aude wrote:

the sorting order used to be maintained on meta wiki for pywikibot, so someone would have needed to add it there in the past and was not something deployers dealt with.

Just now noticing this bug. The Meta sort order pages have a Scribunto module in place to alert Meta sysops when they’re missing languages, but the module was apparently broken for well over a year. With the module now fixed, we’ll be better about updating the sort order there.

daniel closed this task as Resolved.Aug 31 2015, 5:30 PM
daniel claimed this task.
daniel subscribed.

All patches merged

daniel moved this task from Review to Done on the Wikidata-Sprint-2015-08-18 board.Aug 31 2015, 6:37 PM
matej_suchanek removed a project: Patch-For-Review.Sep 1 2015, 8:50 AM
matej_suchanek removed a subscriber: gerritbot.
gerritbot added a comment.Sep 1 2015, 9:04 AM

Change 235199 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Strict code order in InterwikiSorter

https://gerrit.wikimedia.org/r/235199

gerritbot added a project: Patch-For-Review.Sep 1 2015, 9:04 AM
thiemowmde reopened this task as Open.Sep 1 2015, 9:05 AM

Can we please stop closing tickets purely based on the impression that the currently linked patches are merged?

thiemowmde claimed this task.Sep 1 2015, 9:05 AM
thiemowmde lowered the priority of this task from High to Low.
thiemowmde moved this task from Done to Review on the Wikidata-Sprint-2015-08-18 board.
thiemowmde added projects: patch-welcome, good first task.
JanZerebecki mentioned this in T111023: [Task] Move languagelink sidebar sort order from wikibase to operations/mediawiki-config.Sep 1 2015, 10:33 AM
gerritbot added a comment.Sep 1 2015, 10:36 AM

Change 235199 merged by jenkins-bot:
Strict code order in InterwikiSorter

https://gerrit.wikimedia.org/r/235199

Diffusion mentioned this in rMEXT52630f0003bf: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 1 2015, 10:36 AM
thiemowmde mentioned this in rEWBA13f88f85af7e: Strict code order in InterwikiSorter.Sep 1 2015, 10:36 AM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-09-01.Sep 1 2015, 12:47 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the Wikidata-Sprint-2015-09-01 board.
thiemowmde closed this task as Resolved.Sep 2 2015, 12:24 PM
thiemowmde moved this task from Review to Done on the Wikidata-Sprint-2015-09-01 board.
Diffusion mentioned this in rMEXTee0aadd9f696: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 7 2015, 1:32 PM
thiemowmde mentioned this in rEWBA2e24c11b9644: Remove requirement that an "alphabetic" sort order must be defined.Sep 7 2015, 1:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL