Default:
OOUI:
Screenshot made at Special:OAuthManageMyGrants/update.
Tgr | |
Jun 19 2015, 2:22 AM |
F180912: htmlform-progressive-button-ooui.png | |
Jun 19 2015, 2:22 AM |
F180913: htmlform-progressive-button-old.png | |
Jun 19 2015, 2:22 AM |
Default:
Screenshot made at Special:OAuthManageMyGrants/update.
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core | |||
Open | None | T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core | |||
Open | None | T98880 Improve OAuth management interface | |||
Resolved | Tgr | T96154 OOUI-ify the management interfaces (special pages) for OAuth | |||
Resolved | matmarex | T100279 Make OOUI display format in MediaWiki's HTMLForm production-ready | |||
Resolved | Tgr | T103046 Progressive buttons broken in OOUIHTMLForm |
Not sure if this is the same as T98903? The button is created via
$form->addButton( 'update', $this->msg( 'mwoauthmanagemygrants-update' )->text(), null, array( 'class' => 'mw-ui-button mw-ui-primary' ) );
Same for destructive buttons (e.g. Special:OAuthManageMyGrants/revoke).
Cherry-picking https://gerrit.wikimedia.org/r/#/c/218149/1 does not help, so this is probably an unrelated bug.
Hmm. The current code results in a plain OOUI button with additional 'mw-ui-button mw-ui-primary' CSS classes, which obviously doesn't work well. We should either try to "parse" the 'class' attribute and convert some magic classes to OOUI\ButtonInputWidget 'flags' config option, or allow passing flags to addButton() somehow and update callers. Not sure which would make more sense.
I don't know which is easier to implement, but from a distance, passing flags certainly sounds cleaner.
Hmm. It seems that you should already be able to do it. Does passing array( 'flags' => array( 'primary' ) ) instead of array( 'class' => 'mw-ui-button mw-ui-primary' ) give the desired result?
(You'll actually want array( 'flags' => array( 'primary', 'progressive' ) ); OOUI 'primary' flag doesn't include 'progressive' flag, unlike MediaWiki UI.)