Maniphest T103047

Horizontal scroll on gather collextions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 19 2015, 2:53 AM

Tags

Referenced Files

None

Subscribers

Description

No doubt due to box sizing patch (cc @Florian)

Only possible to see on mobile browser.
https://en.m.wikipedia.org/wiki/Special:Gather/id/35/Click_edit

Details

	Subject	Repo	Branch	Lines +/-
	Fix horizontals scroll on collections	mediawiki/extensions/Gather	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rEGAT3f975b0b5c82: Fix horizontals scroll on collections
rMEXTfeec54b992d6: Updated mediawiki/extensions Project: mediawiki/extensions/Gather…
Mentioned Here: T86366: Revisit box-sizing: border-box for everything in MobileFrontend

Event Timeline

Jdlrobson created this task.Jun 19 2015, 2:53 AM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Mobile-Web-Sprint-49-Wayne's-World.

Jdlrobson moved this task to Needs Analysis on the Mobile-Web-Sprint-49-Wayne's-World board.

Jdlrobson added subscribers: Jdlrobson, Florian.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 19 2015, 2:53 AM

Jdlrobson added a project: Gather.Jun 19 2015, 3:38 PM

Jdlrobson set Security to None.

Jdlrobson moved this task from Needs triage to This Sprint on the Gather board.

Jdlrobson added a project: Reading-Web-Sprint-50-The-X-Files.Jun 19 2015, 5:59 PM

• KLans_WMF removed a project: Mobile-Web-Sprint-49-Wayne's-World.Jun 22 2015, 4:40 PM

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-50-The-X-Files board.Jun 22 2015, 5:09 PM

Jdlrobson claimed this task.Jun 22 2015, 6:03 PM

Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-50-The-X-Files board.

Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jun 22 2015, 6:07 PM

• bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-50-The-X-Files board.Jun 22 2015, 9:02 PM

Change 219874 had a related patch set uploaded (by Jdlrobson):
Fix horizontals scroll on collections

https://gerrit.wikimedia.org/r/219874

gerritbot added a project: Patch-For-Review.Jun 22 2015, 9:28 PM

Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jun 22 2015, 9:32 PM

• bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-50-The-X-Files board.Jun 22 2015, 9:34 PM

Change 219874 merged by jenkins-bot:
Fix horizontals scroll on collections

https://gerrit.wikimedia.org/r/219874

Diffusion mentioned this in rMEXTfeec54b992d6: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jun 22 2015, 9:36 PM

Jdlrobson mentioned this in rEGAT3f975b0b5c82: Fix horizontals scroll on collections.Jun 22 2015, 9:36 PM

https://gerrit.wikimedia.org/r/219874 (branch master): WMF-deploy-2015-06-23_(1.26wmf11)

@Jdlrobson: What exactly is/was the problem here?

Border box issues. Visiting collections page on a phone would show a horizontal scroll.

5:40:20 PM <phuedx> jdlrobson: sorry to break your catchup on pagination but is https://phabricator.wikimedia.org/T103047 a thing?
5:40:35 PM <phuedx> the border-box kerfuffle was reverted and i haven't seen any issues

… on an iPhone 6.

Verified locally by cherry picking 220008 and then reverting and reapplying 219874.

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-50-The-X-Files board.Jun 25 2015, 5:02 PM

phuedx removed a project: Patch-For-Review.Jun 26 2015, 10:32 AM

Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM