Page MenuHomePhabricator

VE in Flow throws exception when pasting/typing URL into internal link field
Closed, ResolvedPublic

Description

Because the code handling this case in VE accesses ve.init.target.doc, which is currently undefined in Flow (but probably shouldn't be).

Event Timeline

Catrope created this task.Jun 19 2015, 8:19 PM
Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope added a project: StructuredDiscussions.
Catrope added a subscriber: Catrope.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 19 2015, 8:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 220378 had a related patch set uploaded (by Mattflaschen):
MWLinkAnnotationInspector: Get HtmlDocument in a different way

https://gerrit.wikimedia.org/r/220378

Change 220378 merged by jenkins-bot:
MWLinkAnnotationInspector: Get HtmlDocument in a different way

https://gerrit.wikimedia.org/r/220378

In beta the link inspector becomes sticky after inserting :

TypeError: this.getFragment(...) is null load.php:768:820

and

[Error] TypeError: null is not an object (evaluating 'this.getFragment().getDocument')
	onInternalLinkChange (undefined, line 225)
	emit
	setAnnotation (load.php, line 554)
	(anonymous function) (load.php, line 613)
	(anonymous function) (load.php, line 71)
	(anonymous function) (load.php, line 47)
	fire (load.php, line 45)
	add (load.php, line 45)
	(anonymous function) (load.php, line 47)
	each (load.php, line 5)
	(anonymous function) (load.php, line 47)
	Deferred (load.php, line 47)
	then (load.php, line 46)
	execute (load.php, line 72)
	teardown (load.php, line 59)
	(anonymous function) (load.php, line 67)

Change 221798 had a related patch set uploaded (by Catrope):
Follow-up 8112c3ba30: fix JS error on link inspector teardown

https://gerrit.wikimedia.org/r/221798

Change 221798 merged by jenkins-bot:
Follow-up 8112c3ba30: fix JS error on link inspector teardown

https://gerrit.wikimedia.org/r/221798

Looks good on beta.

DannyH closed this task as Resolved.Jun 30 2015, 7:38 PM
DannyH added a subscriber: DannyH.