Page MenuHomePhabricator
Create Task
Maniphest T103224

Add an option to ignore file extension
Closed, ResolvedPublic
Actions

Description

When $wgCheckFileExtensions is set to false, UW still limits the allowed extensions to $wgFileExtensions:

This wiki does not accept filenames that end in the extension ".***".

The checks are preformed near line 444 of mw.UploadWizardUpload.js

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/UploadWizardmaster+6 -3Added support to ignore file extension
Customize query in gerrit

Related Objects

Event Timeline

zhuyifei1999 created this task.Jun 20 2015, 6:12 AM
zhuyifei1999 raised the priority of this task from to Needs Triage.
zhuyifei1999 updated the task description. (Show Details)
zhuyifei1999 added a project: UploadWizard.
zhuyifei1999 added subscribers: zhuyifei1999, Steinsplitter.
Restricted Application added a project: Multimedia. · View Herald TranscriptJun 20 2015, 6:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
zhuyifei1999 added a subscriber: Rillke.Jun 20 2015, 6:13 AM
Steinsplitter triaged this task as Medium priority.Jun 20 2015, 3:24 PM
Steinsplitter set Security to None.
Aklapper added a comment.Jun 22 2015, 9:51 AM

@Steinsplitter: Did you set the priority because you plan to work on this or now somebody planning to work on this?

Aklapper lowered the priority of this task from Medium to Low.Jun 30 2015, 2:30 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptJun 30 2015, 2:30 PM
MarkTraceur added a project: good first task.Jun 30 2015, 2:33 PM
Steinsplitter raised the priority of this task from Low to Needs Triage.Jun 30 2015, 2:34 PM
MarkTraceur added a subscriber: MarkTraceur.Jun 30 2015, 2:34 PM

I'm marking this as "easy" because to me it sounds like about two lines of code. New coders, feel free to work on this bug at your leisure.

Steinsplitter, I don't think this affects any in-production wikis, and I'm not sure who in their right mind doesn't set that variable.

MarkTraceur triaged this task as Low priority.Jun 30 2015, 2:35 PM
zhuyifei1999 claimed this task.Jun 30 2015, 3:38 PM

This affects Commons Archive, where the file extension checks are hacked to be ignored.
I'll take this task for now and see if I can fix this.

MarkTraceur added a comment.Jun 30 2015, 3:40 PM

That is not a production wiki.

Rillke added a comment.Jun 30 2015, 4:15 PM
In T103224#1414008, @MarkTraceur wrote:

That is not a production wiki.

Doesn't matter. We are developing MediaWiki and not WikimediaSoftare. @zhuyifei1999 thanks for picking this up.

gerritbot added a subscriber: gerritbot.Jul 1 2015, 9:17 AM

Change 222085 had a related patch set uploaded (by Zhuyifei1999):
Added support to ignore file extension

https://gerrit.wikimedia.org/r/222085

gerritbot added a project: Patch-For-Review.Jul 1 2015, 9:17 AM
gerritbot added a comment.Sep 2 2015, 3:46 PM

Change 222085 merged by jenkins-bot:
Added support to ignore file extension

https://gerrit.wikimedia.org/r/222085

matmarex mentioned this in rEUWIe0d4ab7ccc6a: Added support to ignore file extension.Sep 2 2015, 3:46 PM
Diffusion mentioned this in rMEXTefcf1e5f9996: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Sep 2 2015, 3:46 PM
Forrestbot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 2 2015, 4:00 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 5:51 PM
matmarex closed this task as Resolved.Sep 9 2015, 6:08 PM
matmarex added a subscriber: matmarex.
Jdforrester-WMF moved this task from Backlog to Done on the Multimedia board.Sep 15 2015, 4:28 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL