Page MenuHomePhabricator
Create Task
Maniphest T103440

Write tests for modules that are in stable and have low code coverage
Closed, DeclinedPublic
Actions

Description

Despite these features being surfaced in stable they have very little code coverage:

  • mobile.editor.overlay (44.29%)
  • mobile.abusefilter (43.48%)
  • mobile.contentOverlays (19.05%)
  • mobile.gallery (19.51%)

Let's get these up to at absolute minimum 50%

Update:
Thanks to Florian we have already improved the coverage of mobile.talk.overlays which was previously 43.75% of statements

Details

SubjectRepoBranchLines +/-
QA: Add unit tests for TalkSectionOverlaymediawiki/extensions/MobileFrontendmaster+81 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jun 22 2015, 11:37 PM
Jdlrobson raised the priority of this task from to Medium.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: MobileFrontend, Web-Team-Backlog.
Jdlrobson added subscribers: • ggellerman, Tgr, hashar and 3 others.
Jdlrobson renamed this task from Write tests for talk module to Write tests for modules that are in stable and have low code coverage.Jun 22 2015, 11:41 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson set Security to None.
Jdlrobson added a project: Reading-Web-Sprint-50-The-X-Files.
hashar unsubscribed.Jun 23 2015, 12:29 PM
gerritbot subscribed.Jun 23 2015, 5:22 PM

Change 220183 had a related patch set uploaded (by Florianschmidtwelzow):
QA: Add unit tests for TalkSectionOverlay

https://gerrit.wikimedia.org/r/220183

gerritbot added a project: Patch-For-Review.Jun 23 2015, 5:22 PM
phuedx moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jun 24 2015, 11:53 AM
gerritbot added a comment.Jun 24 2015, 7:57 PM

Change 220183 merged by jenkins-bot:
QA: Add unit tests for TalkSectionOverlay

https://gerrit.wikimedia.org/r/220183

Florian mentioned this in rMEXT7a16dab55045: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jun 24 2015, 7:57 PM
Jdlrobson mentioned this in rEMFR8dc73eac0c71: QA: Add unit tests for TalkSectionOverlay.Jun 24 2015, 7:57 PM
• Forrestbot added a project: WMF-deploy-2015-06-30_(1.26wmf12).Jun 24 2015, 8:00 PM
• Forrestbot subscribed.
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
Jdlrobson updated the task description. (Show Details)Jul 1 2015, 12:18 AM
Jdlrobson removed a project: Patch-For-Review.
• KLans_WMF removed a project: Reading-Web-Sprint-50-The-X-Files.Jul 1 2015, 3:51 PM
Jdlrobson moved this task from Backlog to Team: web on the MobileFrontend board.Aug 4 2015, 6:36 PM
Jdlrobson removed a project: Web-Team-Backlog.Sep 18 2015, 8:50 PM
• bmansurov added a project: Google-Code-In-2015.Nov 30 2015, 12:48 PM
• bmansurov subscribed.
Aklapper moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 1 2015, 2:14 PM
Jdlrobson added a subtask: T112568: `grunt qunit` tool no longer works.Dec 7 2015, 4:26 PM
Sn1per claimed this task.Dec 26 2015, 11:11 PM
Sn1per removed Sn1per as the assignee of this task.Dec 27 2015, 8:20 PM
Sn1per subscribed.

Requires T112568 to be unblocked first

Jdlrobson closed this task as Declined.Feb 2 2016, 1:01 AM
Jdlrobson claimed this task.
Jdlrobson closed subtask T112568: `grunt qunit` tool no longer works as Declined.

Not actionable at current time and possibly out of date. If someone wants to run qunit test coverage report and open a new task please do :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL