Page MenuHomePhabricator

External link modal dialog should trim whitespace when checking for validity
Closed, ResolvedPublic1 Story Points

Description

FF 38.0.1, Linux

Steps to reproduce:

The URL field will have a red error border, and the Insert button is disabled.

More polite behavior would be to ignore the whitespace when testing for URL validity, and strip it if Insert is pressed.

Event Timeline

awight created this task.Jun 23 2015, 1:26 AM
awight raised the priority of this task from to Needs Triage.
awight updated the task description. (Show Details)
awight added a project: VisualEditor.
awight added a subscriber: awight.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2015, 1:26 AM
Krenair claimed this task.Jul 25 2015, 6:42 PM

Change 227004 had a related patch set uploaded (by Alex Monk):
Trim external link before validating

https://gerrit.wikimedia.org/r/227004

Jdforrester-WMF renamed this task from External link modal dialog should trim whitespace to External link modal dialog should trim whitespace when checking for validity.Jul 25 2015, 9:53 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF triaged this task as Normal priority.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF removed a project: Patch-For-Review.

Change 227004 merged by jenkins-bot:
Trim external link before validating

https://gerrit.wikimedia.org/r/227004