Page MenuHomePhabricator

Blueprint skin crashes in Title::equals() if you blank the title
Closed, ResolvedPublic

Description

I want to hide the title on the Data and developer hub home page. How do I hide the main page gives the wikitext recipe:

{{DISPLAYTITLE:<span style="position: absolute; clip: rect(1px 1px 1px 1px); clip: rect(1px, 1px, 1px, 1px);">{{FULLPAGENAME}}</span>}}

but when I added that, the Blueprint skin crashes with

PHP Error: Argument 1 passed to Title::equals() must be an instance of Title, null given
#0 /srv/vagrant/mediawiki/includes/Title.php(4218): MWExceptionHandler::handleError()
#1 /srv/vagrant/mediawiki/skins/Blueprint/src/BlueprintSkinTemplate.php(14): Title->equals()
#2 (): Closure$BlueprintSkinTemplate::execute()
#3 /srv/vagrant/mediawiki/skins/Blueprint/src/BlueprintSkinTemplate.php(18): array_map()
...

Event Timeline

Spage raised the priority of this task from to High.
Spage updated the task description. (Show Details)
Spage added a project: Blueprint.
Spage subscribed.
Spage renamed this task from Blueprint skin crashes in Title::equals() with empty title to Blueprint skin crashes in Title::equals() if you blank the title.Jun 23 2015, 6:59 AM
Spage updated the task description. (Show Details)
Spage set Security to None.

Change 220084 had a related patch set uploaded (by Spage):
Don't use data['title'] in sidebar logic

https://gerrit.wikimedia.org/r/220084

Spage moved this task from Backlog to Needs Review / Feedback on the Blueprint board.

My patch fixes this on devhub.

Change 220084 merged by Prtksxna:
Don't use data['title'] in sidebar logic

https://gerrit.wikimedia.org/r/220084