Page MenuHomePhabricator
Create Task
Maniphest T103500

Editing a collection shows mw-ui-icon-tick-disabled on added items.
Closed, ResolvedPublic
Actions

Description

When editing a collection, it opens and all the added items have the check mark disabled.

It should be green (enabled) because the items are added.

Check out demonstration gif (reproduced with latest chrome on beta cluster Jun 23 14:30 CEST):

Diving into the css you can see that they actually have the class mw-ui-icon-tick-disabled on them, so it seems like it is a JS regression and not a CSS one.

It would be great to see if we can get this fixed before branch cut.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Gathermaster+78 -9Ensure correct icon in used in edit collection overlay
Customize query in gerrit

Related Objects

Event Timeline

Jhernandez created this task.Jun 23 2015, 12:32 PM
Jhernandez raised the priority of this task from to High.
Jhernandez updated the task description. (Show Details)
Jhernandez added a project: Reading-Web-Sprint-50-The-X-Files.
Jhernandez moved this task to To Do on the Reading-Web-Sprint-50-The-X-Files board.
Jhernandez added a subscriber: Jhernandez.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2015, 12:32 PM
Jdlrobson added a subscriber: Jdlrobson.Jun 23 2015, 4:26 PM

isMember needs to be set to true on the pages...

Jdlrobson moved this task from To Do to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jun 23 2015, 4:31 PM
gerritbot added a subscriber: gerritbot.Jun 23 2015, 4:31 PM

Change 220169 had a related patch set uploaded (by Jdlrobson):
Ensure correct icon in used in edit collection overlay

https://gerrit.wikimedia.org/r/220169

gerritbot added a project: Patch-For-Review.Jun 23 2015, 4:31 PM
Jdlrobson claimed this task.Jun 23 2015, 4:31 PM
• rmoen moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-50-The-X-Files board.Jun 23 2015, 11:28 PM
gerritbot added a comment.Jun 23 2015, 11:30 PM

Change 220169 merged by jenkins-bot:
Ensure correct icon in used in edit collection overlay

https://gerrit.wikimedia.org/r/220169

• Konfused-Kitten mentioned this in rMEXT34f4657554f7: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jun 23 2015, 11:30 PM
• rmoen mentioned this in rEGATa598668b0b40: Ensure correct icon in used in edit collection overlay.Jun 23 2015, 11:31 PM
Forrestbot added a project: WMF-deploy-2015-06-30_(1.26wmf12).Jun 24 2015, 12:00 AM
Forrestbot added a subscriber: Forrestbot.
phuedx closed this task as Resolved.Jun 25 2015, 10:07 AM
phuedx added a subscriber: phuedx.

Verified on BC.

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-50-The-X-Files board.Jun 25 2015, 10:07 AM
phuedx removed a project: Patch-For-Review.Jun 26 2015, 10:32 AM
Legoktm removed a subscriber: Forrestbot.Jun 29 2015, 5:49 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL