Maniphest T103612

CodeEditor causes "TypeError: $.ucFirst is not a function" due to missing dependency
Closed, ResolvedPublic
Actions

Assigned To

• Mattflaschen-WMF

Authored By

	He7d3r
	Jun 23 2015, 9:52 PM

Tags

Referenced Files

None

Subscribers

Description

The code uses a function from "jquery.mwExtension" without declaring a dependency on it:
https://github.com/wikimedia/mediawiki-extensions-CodeEditor/blob/3e98b4544f2e4798d921808d9d2ad4e5999ef1d9/modules/jquery.codeEditor.js#L551

This results in:

TypeError: $.ucFirst is not a function

Details

	Subject	Repo	Branch	Lines +/-
	ucFirst has been deprecated, so inline it	mediawiki/extensions/CodeEditor	master	+7 -2

Customize query in gerrit

Related Objects

Mentioned In: rMEXT9c5490ed6aff: Updated mediawiki/extensions Project: mediawiki/extensions/CodeEditor…
rECEDa7f5ae257cf1: ucFirst has been deprecated, so inline it

Event Timeline

He7d3r created this task.Jun 23 2015, 9:52 PM

He7d3r raised the priority of this task from to Needs Triage.

He7d3r updated the task description. (Show Details)

He7d3r added projects: JavaScript, Regression.

He7d3r subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2015, 9:52 PM

He7d3r set Security to None.Jun 23 2015, 10:18 PM

He7d3r added a subscriber: ori.

Krenair added a project: CodeEditor.Jun 23 2015, 10:41 PM

Krenair subscribed.

• Mattflaschen-WMF claimed this task.Jun 24 2015, 3:12 AM

Change 220382 had a related patch set uploaded (by Mattflaschen):
ucFirst has been deprecated, so inline it

https://gerrit.wikimedia.org/r/220382

gerritbot added a project: Patch-For-Review.Jun 24 2015, 3:40 AM

Change 220382 merged by jenkins-bot:
ucFirst has been deprecated, so inline it

https://gerrit.wikimedia.org/r/220382

• Mattflaschen-WMF mentioned this in rECEDa7f5ae257cf1: ucFirst has been deprecated, so inline it.Jun 24 2015, 3:50 AM

• Mattflaschen-WMF mentioned this in rMEXT9c5490ed6aff: Updated mediawiki/extensions Project: mediawiki/extensions/CodeEditor….

Krinkle closed this task as Resolved.Jun 24 2015, 3:55 AM

Krinkle triaged this task as High priority.

Krinkle subscribed.

https://gerrit.wikimedia.org/r/220382 (branch master): WMF-deploy-2015-06-30_(1.26wmf12)

Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM