Page MenuHomePhabricator
Create Task
Maniphest T103613

[Regression] Toast icon doesn't show on error toasts
Closed, ResolvedPublic
Actions

Description

Generate a toast with the error class using this JavaScript:

mw.mobileFrontend.require( 'toast' ).show( 'test' ,'error toast' )

Failed to load resource: the server responded with a status of 404 (Not Found)
Toast image is in wrong place.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+0 -0Show toast error icon
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jun 23 2015, 9:59 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Reading-Web-Sprint-50-The-X-Files, MobileFrontend, Readers-Web-Backlog.
Jdlrobson moved this task to Needs Analysis on the Reading-Web-Sprint-50-The-X-Files board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2015, 9:59 PM
phuedx edited projects, added good first task; removed Readers-Web-Backlog.Jun 26 2015, 4:56 PM
phuedx set Security to None.
Jdlrobson renamed this task from Failed to load resource: the server responded with a status of 404 (Not Found) to Toast icon doesn't show on error toasts.Jul 1 2015, 12:19 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
KLans_WMF renamed this task from Toast icon doesn't show on error toasts to [Regression]: Toast icon doesn't show on error toasts.Jul 1 2015, 3:49 PM
KLans_WMF triaged this task as Medium priority.
KLans_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-50-The-X-Files board.
phuedx renamed this task from [Regression]: Toast icon doesn't show on error toasts to [Regression] Toast icon doesn't show on error toasts.Jul 1 2015, 4:05 PM
Jdlrobson claimed this task.Jul 1 2015, 6:10 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-50-The-X-Files board.
gerritbot added a subscriber: gerritbot.Jul 1 2015, 6:14 PM

Change 222155 had a related patch set uploaded (by Jdlrobson):
Show toast error icon

https://gerrit.wikimedia.org/r/222155

gerritbot added a project: Patch-For-Review.Jul 1 2015, 6:14 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jul 1 2015, 6:35 PM
gerritbot added a comment.Jul 1 2015, 8:07 PM

Change 222155 merged by jenkins-bot:
Show toast error icon

https://gerrit.wikimedia.org/r/222155

Diffusion mentioned this in rMEXTd7206d18777b: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jul 1 2015, 8:07 PM
• Konfused-Kitten mentioned this in rEMFRdffc08db2952: Show toast error icon.Jul 1 2015, 8:07 PM
phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-50-The-X-Files board.Jul 1 2015, 8:08 PM
Forrestbot added a project: WMF-deploy-2015-07-07_(1.26wmf13).Jul 1 2015, 9:00 PM
phuedx closed this task as Resolved.Jul 2 2015, 4:03 AM
phuedx added a subscriber: phuedx.

Verified on BC.

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-50-The-X-Files board.Jul 2 2015, 4:03 AM
phuedx removed a project: Patch-For-Review.Jul 6 2015, 6:49 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL