Page MenuHomePhabricator

Update meta_p to contain accurate canonical server endpoints
Closed, ResolvedPublic

Description

Various tools are broken that:

  1. Read canonical server from meta_p (as was encouraged in the past to avoid hardcoding anything).
  2. Don't handle redirects.

One of them is OrphanTalk. When submitting the form, an internal server error is thrown as the API request returns no content. It's making requests over HTTP instead of HTTPS, which are now redirects.

I've pushed an update into the base library that fixes redirect support[1], but it will take some time for all tool maintainers using this library to update their tool. And I myself also don't have time to update dozens of tools right now.


[1] https://github.com/Krinkle/toollabs-base/commit/bea7ca891: cURL maxRedirects doens't work unless followLocation is enabled.

Event Timeline

Krinkle raised the priority of this task from to Unbreak Now!.
Krinkle updated the task description. (Show Details)
Krinkle added projects: Cloud-VPS, Toolforge.
Krinkle subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle set Security to None.

This was a simple fix as the list of canonical URL had been updated; a simple run of maintain-replicas updated the meta table with up-to-date information which uses https in the canonical URLs.

coren claimed this task.