The app requests confirmation if you are about to delete the entire history. it doesn't if you choose to delete one item.
I guess the reasoning is that deleting one item is a more involved process and hence unlikely to happen by mistake. I still think it is better to verify before any deletion.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix: Prompt user before selected viewed items are deleted from history | apps/android/wikipedia | master | +25 -10 |
This bug doesn't appear or seems to have been fixed in both the latest alpha & release versions.
Release build: 2.1.131-r-2015-09-28
Alpha build: 2.1.131-alpha-2015-10-14
Change 333313 had a related patch set uploaded (by Probz360):
Fix: Prompt user before selected viewed items are deleted from history
Change 333313 abandoned by Dbrant:
Fix: Prompt user before selected viewed items are deleted from history
Reason:
Abandoning to reduce clutter. Please resurrect if this is picked up again.
It's ok to add this as alert?
Title: Delete item from history
Message: This action will delete the item of your browsing history, and close tab if is open. Are you sure?
Actions: No - Yes
If this is ok I can do the change.
Sorry, let's actually not do this. We're currently refactoring the History screen anyway, and part of the refactor is to add "Undo" snackbars when deleting one ore more items from history. The "undo" interaction is a better substitute for a modal "are you sure" dialog.