Page MenuHomePhabricator
Create Task
Maniphest T103716

EnableFlow broken (shows blank page) on MediaWiki.org
Closed, ResolvedPublic
Actions

Description

James tried on several pages, and got a completely blank response, with no exception code.

Details

SubjectRepoBranchLines +/-
Pass missing argument to EnableFlowWikitextConversionStrategymediawiki/extensions/Flowwmf/1.26wmf11+1 -0
Pass missing argument to EnableFlowWikitextConversionStrategymediawiki/extensions/Flowmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

• Mattflaschen-WMF created this task.Jun 24 2015, 5:24 PM
• Mattflaschen-WMF raised the priority of this task from to Unbreak Now!.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added a project: StructuredDiscussions.
• Mattflaschen-WMF added subscribers: • Mattflaschen-WMF, Jdforrester-WMF.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJun 24 2015, 5:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Legoktm subscribed.Jun 24 2015, 5:35 PM
2015-06-24 16:15:02 mw1040 mediawikiwiki fatal INFO: [3bdcd1fb] /wiki/Special:EnableFlow   ErrorException from line 87 of /srv/mediawiki/php-1.26wmf11/extensions/Flow/includes/Import/Wikitext/ConversionStrategy.php: PHP Error: Argument 4 passed to Flow\Import\Wikitext\ConversionStrategy::__construct() must be an instance of array, string given
#0 /srv/mediawiki/php-1.26wmf11/extensions/Flow/includes/Import/Wikitext/ConversionStrategy.php(87): MWExceptionHandler::handleError()
#1 /srv/mediawiki/php-1.26wmf11/extensions/Flow/includes/Specials/SpecialEnableFlow.php(106): Flow\Import\Wikitext\ConversionStrategy->__construct()
#2 /srv/mediawiki/php-1.26wmf11/includes/htmlform/HTMLForm.php(578): Flow\Specials\SpecialEnableFlow->onSubmit()
#3 /srv/mediawiki/php-1.26wmf11/includes/htmlform/HTMLForm.php(501): HTMLForm->trySubmit()
#4 /srv/mediawiki/php-1.26wmf11/includes/htmlform/HTMLForm.php(516): HTMLForm->tryAuthorizedSubmit()
#5 /srv/mediawiki/php-1.26wmf11/includes/specialpage/FormSpecialPage.php(150): HTMLForm->show()
#6 /srv/mediawiki/php-1.26wmf11/includes/specialpage/SpecialPage.php(384): FormSpecialPage->execute()
#7 /srv/mediawiki/php-1.26wmf11/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run()
#8 /srv/mediawiki/php-1.26wmf11/includes/MediaWiki.php(249): SpecialPageFactory::executePath()
#9 /srv/mediawiki/php-1.26wmf11/includes/MediaWiki.php(668): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.26wmf11/includes/MediaWiki.php(465): MediaWiki->main()
#11 /srv/mediawiki/php-1.26wmf11/index.php(41): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include()
#13 {main} {"private":false}
Legoktm added a comment.Jun 24 2015, 5:38 PM

Caused by rEFLW43f89bec97e4: Add option to conversion script to skip pages with a certain template.

gerritbot subscribed.Jun 24 2015, 5:41 PM

Change 220507 had a related patch set uploaded (by Legoktm):
Pass missing argument to EnableFlowWikitextConversionStrategy

https://gerrit.wikimedia.org/r/220507

gerritbot added a project: Patch-For-Review.Jun 24 2015, 5:41 PM
SBisson subscribed.Jun 24 2015, 5:42 PM

Any volunteer to manual test this until we have good automated tests? :)

Legoktm claimed this task.Jun 24 2015, 5:43 PM
Legoktm mentioned this in T89169: Log php fatals with full backtraces again (fatal.log on fluorine).Jun 24 2015, 5:47 PM
gerritbot added a comment.Jun 24 2015, 5:49 PM

Change 220507 merged by jenkins-bot:
Pass missing argument to EnableFlowWikitextConversionStrategy

https://gerrit.wikimedia.org/r/220507

Legoktm mentioned this in rMEXT7c40d7775549: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Jun 24 2015, 5:49 PM
SBisson added a project: Collaboration-Team-Sprint-D-2015-06-30.Jun 24 2015, 5:49 PM
SBisson set Security to None.
Legoktm mentioned this in rEFLW35d75964dfb2: Pass missing argument to EnableFlowWikitextConversionStrategy.Jun 24 2015, 5:49 PM
SBisson moved this task from Sprint D - ends July 1 to QA Review on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 24 2015, 5:49 PM
gerritbot added a comment.Jun 24 2015, 5:50 PM

Change 220514 had a related patch set uploaded (by Legoktm):
Pass missing argument to EnableFlowWikitextConversionStrategy

https://gerrit.wikimedia.org/r/220514

gerritbot added a comment.Jun 24 2015, 5:59 PM

Change 220514 merged by Legoktm:
Pass missing argument to EnableFlowWikitextConversionStrategy

https://gerrit.wikimedia.org/r/220514

Legoktm mentioned this in rMW416293b4b8ab: Updated mediawiki/core Project: mediawiki/extensions/Flow….Jun 24 2015, 5:59 PM
Legoktm mentioned this in rEFLW1ede61a88e2e: Pass missing argument to EnableFlowWikitextConversionStrategy.
• Mattflaschen-WMF added a comment.Jun 24 2015, 6:00 PM

Yeah, I'll test this on Mondays as well (I'm also doing no-JS).

• Forrestbot added projects: WMF-deploy-2015-06-23_(1.26wmf11), WMF-deploy-2015-06-30_(1.26wmf12).Jun 24 2015, 6:00 PM
• Forrestbot subscribed.
Legoktm closed this task as Resolved.Jun 24 2015, 6:03 PM

Backported and deployed.

Catrope reopened this task as Open.Jun 25 2015, 5:36 PM
Catrope closed this task as Resolved.Jun 25 2015, 8:24 PM
Catrope subscribed.
• DannyH moved this task from QA Review to Done on the Collaboration-Team-Sprint-D-2015-06-30 board.Jun 26 2015, 5:45 PM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Jun 30 2015, 7:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL