Page MenuHomePhabricator
Create Task
Maniphest T103728

Diff not centered
Closed, ResolvedPublic
Actions

Description

@KHammerstein pointed out that if you visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/226666?mobileaction=beta
the diff and the fixed info panel at the bottom are not center aligned.

They should be.

Screen Shot 2015-06-24 at 11.52.24 AM.png (655×1 px, 53 KB)

Blocked on:
Need a mock to show how it should look.
Note Baha's comments:

  • Should the user info be centered
  • I think the left and right paddings should be removed now that the content is aligned in the center: http://i.imgur.com/qQHRz6K.png

Mock

diff-width-19.png (805×1 px, 174 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+22 -8Diff should be centered in beta
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jun 24 2015, 6:49 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Readers-Web-Backlog, Reading-Web-Sprint-50-The-X-Files.
Jdlrobson added subscribers: • Moushira, bmansurov, phuedx and 5 others.
• KHammerstein merged a task: T103729: Set max-width for diff pages.Jun 24 2015, 6:53 PM
phuedx removed a project: Readers-Web-Backlog.Jun 26 2015, 4:53 PM
phuedx set Security to None.
• KLans_WMF triaged this task as Medium priority.Jul 1 2015, 3:45 PM
• KLans_WMF edited projects, added Readers-Web-Backlog; removed Reading-Web-Sprint-50-The-X-Files.
• KLans_WMF moved this task from Incoming to 2014-15 Q4 on the Readers-Web-Backlog board.
gerritbot added a subscriber: gerritbot.Jul 29 2015, 11:15 PM

Change 227906 had a related patch set uploaded (by Jdlrobson):
Diff should be centered in beta

https://gerrit.wikimedia.org/r/227906

gerritbot added a project: Patch-For-Review.Jul 29 2015, 11:15 PM
Jdlrobson moved this task from 2014-15 Q4 to 2017-18 Q3 on the Readers-Web-Backlog board.Jul 29 2015, 11:18 PM
dr0ptp4kt removed a subscriber: dr0ptp4kt.Jul 30 2015, 11:09 PM
Jdlrobson claimed this task.Aug 4 2015, 12:56 AM
Jdlrobson edited projects, added Reading-Web-Sprint-53-12-Monkeys; removed Readers-Web-Backlog.
Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.
bmansurov added a comment.Aug 4 2015, 5:10 PM

The patch has some questions/comments.

Jdlrobson added a comment.Aug 4 2015, 5:18 PM

For the benefit of non-devs - the question is should the user info bar be fix positioned as well? We are assuming yes.

bmansurov added a comment.Aug 4 2015, 5:27 PM

@KHammerstein ^

Jdlrobson moved this task from Code Review to Doing on the Reading-Web-Sprint-53-12-Monkeys board.Aug 4 2015, 8:19 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 4 2015, 9:11 PM
phuedx changed the task status from Open to Stalled.Aug 5 2015, 10:17 AM

This is blocked on @KHammerstein/Design.

Jdlrobson reassigned this task from Jdlrobson to • KHammerstein.Aug 5 2015, 4:41 PM

Note patch has been rewritten to center the user info.

Jdlrobson moved this task from Code Review to Needs Analysis on the Reading-Web-Sprint-53-12-Monkeys board.Aug 5 2015, 6:33 PM
Jdlrobson updated the task description. (Show Details)Aug 5 2015, 6:36 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a comment.Aug 12 2015, 12:07 AM

I just went with your suggestion @bmansurov I'm keen to get this off my radar. @KHammerstein can always file a follow up bug.

Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 12 2015, 12:07 AM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-53-12-Monkeys board.Aug 12 2015, 12:23 PM
Jdlrobson moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 12 2015, 3:56 PM
Jdlrobson added a comment.Aug 12 2015, 9:45 PM

This is the design as currently implemented in tablet mode:
http://i.imgur.com/fd8CNLu.png

• KHammerstein updated the task description. (Show Details)Aug 12 2015, 10:00 PM
bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-53-12-Monkeys board.Aug 13 2015, 12:12 AM
gerritbot added a comment.Aug 13 2015, 12:18 AM

Change 227906 merged by jenkins-bot:
Diff should be centered in beta

https://gerrit.wikimedia.org/r/227906

• Konfused-Kitten mentioned this in rEMFR85c7c8380dcf: Diff should be centered in beta.Aug 13 2015, 12:18 AM
Diffusion mentioned this in rMEXTeb7bf4d11955: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Aug 13 2015, 12:19 AM
Forrestbot added a project: WMF-deploy-2015-08-18_(1.26wmf19).Aug 13 2015, 1:00 AM
Jhernandez removed • KHammerstein as the assignee of this task.Aug 13 2015, 7:50 PM
Jhernandez added a subscriber: Jhernandez.

Can't see it on beta labas, I don't know why. Have a look at the mock kaity posted please.

diff-width-19.png (805×1 px, 174 KB)

It's basically the same but the footer expands full width like the header.

Jhernandez moved this task from Ready for Signoff to To Do on the Reading-Web-Sprint-53-12-Monkeys board.Aug 13 2015, 7:50 PM
Jdlrobson added a comment.Aug 13 2015, 7:54 PM

Beta labs doesn't seem to be running latest code.

Jdlrobson moved this task from To Do to Ready for Signoff on the Reading-Web-Sprint-53-12-Monkeys board.Aug 13 2015, 7:54 PM
Jdlrobson claimed this task.Aug 13 2015, 10:18 PM

Try again - looks updated now! :) -> http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/226666?mobileaction=beta

Jhernandez changed the task status from Stalled to Open.Aug 14 2015, 10:26 AM

Noice! Done! 👍👏

Jhernandez closed this task as Resolved.Aug 14 2015, 10:26 AM
Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-53-12-Monkeys board.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL