Page MenuHomePhabricator

Get rid of the gerrit Debian package and migrate to puppet
Closed, DeclinedPublic

Description

From T103668:

$ apt-cache show gerrit
Package: gerrit
Version: 2.7-rc2-507-g1e7090b-1
Architecture: all
Maintainer: Ryan Lane <rlane@wikimedia.org>
Installed-Size: 30316
Depends: openjdk-6-jre
Priority: extra
Section: net
Filename: pool/main/g/gerrit/gerrit_2.7-rc2-507-g1e7090b-1_all.deb
Size: 30956644
SHA256: c8454f33864bbd5a60fb007d425468f17162f5baced7c73d5ebd6e7995e01ca3
SHA1: a30ab2e6f7ff6c46dff567b8f7a6d7a1a62efd27
MD5sum: 00504ec200c270fd59a1c11f80a55645
Description: Gerrit code review system
$ dpkg -L gerrit
/.
/etc
/etc/init.d
/etc/init.d/gerrit
/etc/default
/etc/default/gerrit
/var
/var/lib
/var/lib/gerrit2
/var/lib/gerrit2/gerrit.war

We no more use that package for Gerrit cause it was a pain in the a**. Instead the .jar is build and uploaded directly to the machine.

The init script isn't in puppet. It attempts to source /etc/default/gerritcodereview which is provided by puppet.

I guess the package also takes care of creating the gerrit2 users.

There is no use for the Debian package since it provides little values. Lets identify what it provides and migrate the bits to puppet.

Event Timeline

hashar raised the priority of this task from to Needs Triage.
hashar updated the task description. (Show Details)
hashar added projects: Gerrit, acl*sre-team.

WFM. Just stuff the jars in a git repo and call it a day with trebuchet (or new deploy system).

The rest can be in puppet.

No, it for some reason the package only takes care of removing the gerrit2 user/group, but not creating them: The maintainer scripts of a package are not shown by "dpkg -L foo", but they're available at /var/lib/dpkg/info/gerrit*.

The gerrit.postrm is executed when gerrit is removed.

fgiunchedi subscribed.

If anything I want to improve the package, not delete it. Declining.