Page MenuHomePhabricator
Create Task
Maniphest T103737

Fix crash bug: https://rink.hockeyapp.net/manage/apps/152731/app_versions/19/crash_reasons/38183462
Closed, ResolvedPublic
Actions

Description

High volume crasher on 4.1.5 - prioritizing for 4.1.6 release.

Details

SubjectRepoBranchLines +/-
saved & history list error handling & testingapps/ios/wikipediamaster+299 -43
restore legacy empty string behavior for titlesapps/ios/wikipediamaster+39 -11
Customize query in gerrit

Related Objects

Event Timeline

• Fjalapeno created this task.Jun 24 2015, 7:58 PM
• Fjalapeno claimed this task.
• Fjalapeno raised the priority of this task from to Needs Triage.
• Fjalapeno updated the task description. (Show Details)
• Fjalapeno added projects: Wikipedia-iOS-App-Backlog, Wikipedia-iOS-App-Development.
• Fjalapeno subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2015, 7:58 PM
• Fjalapeno moved this task from Tasks from Product Backlog to Doing on the Wikipedia-iOS-App-Development board.Jun 24 2015, 7:58 PM
• Fjalapeno mentioned this in rAPIW253d751c6b7e: Fix crash bug due to nil title text. Bug: T103737.Jun 25 2015, 1:44 PM
Diffusion mentioned this in rAPIW0987583048a2: Merge "Fix crash bug due to nil title text. Bug: T103737".Jun 25 2015, 1:44 PM
• Fjalapeno mentioned this in rAPIW971263e46c8a: More preventions for nil title in history.Jun 25 2015, 2:51 PM
• BGerstle-WMF moved this task from Doing to Needs QA on the Wikipedia-iOS-App-Development board.Jun 25 2015, 5:39 PM
• Fjalapeno moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.Jun 26 2015, 12:58 PM
• Fjalapeno moved this task from Engineering Backlog to Needs Prototype on the Wikipedia-iOS-App-Backlog board.
• Fjalapeno moved this task from Needs Prototype to Needs Acceptance Criteria on the Wikipedia-iOS-App-Backlog board.
• Fjalapeno moved this task from Needs Acceptance Criteria to In Development on the Wikipedia-iOS-App-Backlog board.
• BGerstle-WMF claimed this task.Jun 29 2015, 5:38 PM
• BGerstle-WMF moved this task from Needs QA to Doing on the Wikipedia-iOS-App-Development board.
• BGerstle-WMF set Security to None.
gerritbot subscribed.Jun 29 2015, 5:40 PM

Change 221668 had a related patch set uploaded (by Bgerstle):
restore legacy empty string behavior for titles

https://gerrit.wikimedia.org/r/221668

gerritbot added a project: Patch-For-Review.Jun 29 2015, 5:40 PM

Change 221669 had a related patch set uploaded (by Bgerstle):
saved & history list error handling & testing

https://gerrit.wikimedia.org/r/221669

gerritbot added a comment.Jun 29 2015, 6:03 PM

Change 221668 merged by jenkins-bot:
restore legacy empty string behavior for titles

https://gerrit.wikimedia.org/r/221668

• BGerstle-WMF mentioned this in rAPIW76e25c10d613: restore legacy empty string behavior for titles.Jun 29 2015, 6:03 PM
• BGerstle-WMF mentioned this in rAPIW7d37706b7dd5: saved & history list error handling & testing.Jun 29 2015, 6:07 PM
• BGerstle-WMF moved this task from Doing to Needs Code Review on the Wikipedia-iOS-App-Development board.Jun 29 2015, 6:29 PM
• BGerstle-WMF moved this task from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Development board.Jun 30 2015, 2:25 PM
gerritbot added a comment.Jun 30 2015, 2:27 PM

Change 221669 merged by jenkins-bot:
saved & history list error handling & testing

https://gerrit.wikimedia.org/r/221669

• Fjalapeno removed a project: Wikipedia-iOS-App-Backlog.Jul 3 2015, 5:50 PM
Etonkovidova subscribed.Jul 4 2015, 7:56 PM

Checked with 4.1.6.154 on iPad mini iOS 8.2.

In 'Recent pages' - if a page clicked and displayed then navigation(arrows) will refer to navigating through Recent pages only. Is it a regression? It does not happen with Saved pages - the navigation will go normally to previously visited pages not to the pages listed in Saved pages list.

Etonkovidova moved this task from Needs QA to Needs Design Review on the Wikipedia-iOS-App-Development board.Jul 4 2015, 7:57 PM
• Fjalapeno moved this task from Needs Design Review to Ready for PM Signoff on the Wikipedia-iOS-App-Development board.Jul 5 2015, 11:32 PM
• Fjalapeno closed this task as Resolved.Jul 9 2015, 5:23 PM
• Fjalapeno moved this task from Ready for PM Signoff to Released on the Wikipedia-iOS-App-Development board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL