Page MenuHomePhabricator
Create Task
Maniphest T103742

[Regression] Clicking watch star in search results takes me to page
Closed, ResolvedPublic
Actions

Description

Visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Shanghai
Do a search
click the star on the top result
You are taken to the page.
Expected: the watchstar gets updated.

Given the low usage of this feature this might be a good time to remove it instead. Thoughts @JKatzWMF

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+36 -18Search overlay: do not navigate away from the page when a watchstar is clicked
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jun 24 2015, 8:11 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Readers-Web-Backlog, Reading-Web-Sprint-50-The-X-Files.
Jdlrobson moved this task to Incoming on the Readers-Web-Backlog board.
Jdlrobson added subscribers: Jdlrobson, • JKatzWMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2015, 8:11 PM
phuedx renamed this task from Clicking watch star in search results takes me to page to [Regression] Clicking watch star in search results takes me to page.Jun 26 2015, 4:49 PM
phuedx removed a project: Readers-Web-Backlog.
phuedx set Security to None.
bmansurov added a subscriber: bmansurov.Jun 29 2015, 10:11 AM

Also, note that the watchstar does get updated. You can see it by searching the same term again.

phuedx moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-50-The-X-Files board.Jun 30 2015, 10:28 AM
bmansurov claimed this task.Jun 30 2015, 10:44 AM
bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-50-The-X-Files board.
gerritbot added a subscriber: gerritbot.Jun 30 2015, 11:41 AM

Change 221848 had a related patch set uploaded (by Bmansurov):
Search overlay: do not navigate away from the page when a watchstar is clicked

https://gerrit.wikimedia.org/r/221848

gerritbot added a project: Patch-For-Review.Jun 30 2015, 11:41 AM
bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jun 30 2015, 11:42 AM
phuedx moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-50-The-X-Files board.Jun 30 2015, 2:56 PM
bmansurov moved this task from -1 (Needs More Work) to Doing on the Reading-Web-Sprint-50-The-X-Files board.Jun 30 2015, 4:55 PM
bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jun 30 2015, 9:50 PM
gerritbot added a comment.Jul 1 2015, 11:12 AM

Change 221848 merged by jenkins-bot:
Search overlay: do not navigate away from the page when a watchstar is clicked

https://gerrit.wikimedia.org/r/221848

Diffusion mentioned this in rMEXT37a003bb79e1: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jul 1 2015, 11:12 AM
phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-50-The-X-Files board.Jul 1 2015, 11:13 AM
bmansurov mentioned this in rEMFRdb0d31773540: Search overlay: do not navigate away from the page when a watchstar is clicked.Jul 1 2015, 11:13 AM
Forrestbot added a project: WMF-deploy-2015-07-07_(1.26wmf13).Jul 1 2015, 12:00 PM
phuedx closed this task as Resolved.Jul 1 2015, 1:54 PM
phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-50-The-X-Files board.
phuedx added a subscriber: phuedx.
phuedx removed a project: Patch-For-Review.Jul 6 2015, 6:49 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL