|mediawiki/extensions/CentralAuth : master||Use 'centralauth-state-mismatch' message in adminLock() and adminUnlock()|
- Mentioned In
- rECAU66b04287717b: Use 'centralauth-state-mismatch' message in adminLock() and adminUnlock()
rMEXTbe4c827bcdac: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth…
- Mentioned Here
- rECAUa996b1f977ad: * Allow stewards to (un)lock global users using Special:CentralAuth * Log all…
What happened here was, it only detected the conflict only after trying to update the db after even going through the pre-check of whether the account was locked. In the case of centralauth-state-mismatch, it's before attempting to update the db.
It was removed in https://www.mediawiki.org/wiki/Special:Code/MediaWiki/47919. Apparently it was only noticed that centralauth-admin-unhide-nonexistent was still in use then. I think we should change this one to also use state-mismatch message as a non-existent global account to reach adminLock() and adminUnlock() is very unlikely when compared to race conditions like this.