I tried to block https://meta.wikimedia.org/wiki/Special:CentralAuth/CasieBarak6 about a minute before @M7 did it, but failed with the message: <centralauth-admin-lock-nonexistent>
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned In
- rECAU66b04287717b: Use 'centralauth-state-mismatch' message in adminLock() and adminUnlock()
rMEXTbe4c827bcdac: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth… - Mentioned Here
- rECAUa996b1f977ad: * Allow stewards to (un)lock global users using Special:CentralAuth * Log all…
Event Timeline
Comment Actions
Looks like that message was added when locking was implemented but it got removed after somehow rECAUa996b1f977adfdb721c7d98fab1a37f120bc1a32
Comment Actions
What happened here was, it only detected the conflict only after trying to update the db after even going through the pre-check of whether the account was locked. In the case of centralauth-state-mismatch, it's before attempting to update the db.
Comment Actions
It was removed in https://www.mediawiki.org/wiki/Special:Code/MediaWiki/47919. Apparently it was only noticed that centralauth-admin-unhide-nonexistent was still in use then. I think we should change this one to also use state-mismatch message as a non-existent global account to reach adminLock() and adminUnlock() is very unlikely when compared to race conditions like this.
Comment Actions
Change 239567 had a related patch set uploaded (by Glaisher):
Use 'centralauth-state-mismatch' message in adminLock() and adminUnlock()
Comment Actions
Change 239567 merged by jenkins-bot:
Use 'centralauth-state-mismatch' message in adminLock() and adminUnlock()