ForeignAPIFile.php:201"
Closed, ResolvedPublic
Actions

Description

MediaWiki uses [['name' => <name>, 'value' => <value>'], ...] for the image metadata format at varius places. The imageinfo API exposes this via iiprop=metadata, but the default (formatversion=1) JSON formatter swallows fields with a value of boolean false, so value can be missing. This causes warnigns in InstantCommons (and probably breaks some other things).

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	REL1_25	+4 -1	APIQueryImageInfo: Set META_BC_BOOLS for 'value' in 'metadata' block
	mediawiki/core	master	+4 -1	APIQueryImageInfo: Set META_BC_BOOLS for 'value' in 'metadata' block

Customize query in gerrit

Related Objects

Mentioned In: rMW438c7d8cc02f: APIQueryImageInfo: Set META_BC_BOOLS for 'value' in 'metadata' block
rMW5a078a72152b: APIQueryImageInfo: Set META_BC_BOOLS for 'value' in 'metadata' block

Event Timeline

Krinkle created this task.Jun 25 2015, 3:28 AM

Krinkle raised the priority of this task from to Needs Triage.

Krinkle updated the task description. (Show Details)

Krinkle added projects: Wikimedia-production-error, MediaWiki-File-management.

Krinkle added a subscriber: Krinkle.

Restricted Application added a project: Multimedia. · View Herald TranscriptJun 25 2015, 3:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Krinkle added a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Jun 25 2015, 3:29 AM

Or even a malformed response from the Commons imageinfo API. Do we know which files throw this?

Visiting https://translatewiki.net/wiki/File:EscudoMazamitla.gif throws this error.

Restricted Application added a subscriber: Matanya. · View Herald TranscriptJul 6 2015, 8:07 PM

The metadata provided by the Commons API is malformed (looped does not have a value).

looped comes from mediawiki/includes/media/GIFMetadataExtractor.php which always sets it to boolean. The API handles fields with a boolean false value weirdly (compare with the formatversion=2 API response).

Tgr updated the task description. (Show Details)Jul 8 2015, 10:27 PM

Tgr edited projects, added MediaWiki-API; removed MediaWiki-File-management.

Tgr set Security to None.

Change 223698 had a related patch set uploaded (by Legoktm):
APIQueryImageInfo: Set META_BC_BOOLS for 'value' in 'metadata' block

https://gerrit.wikimedia.org/r/223698

gerritbot added a project: Patch-For-Review.Jul 8 2015, 10:53 PM

Legoktm claimed this task.Jul 8 2015, 10:53 PM

Anomie moved this task from Unsorted to Done on the MediaWiki-API board.Jul 9 2015, 1:24 PM

Change 223698 merged by jenkins-bot:
APIQueryImageInfo: Set META_BC_BOOLS for 'value' in 'metadata' block

https://gerrit.wikimedia.org/r/223698

Legoktm mentioned this in rMW5a078a72152b: APIQueryImageInfo: Set META_BC_BOOLS for 'value' in 'metadata' block.Jul 9 2015, 1:32 PM

Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-07-14_(1.26wmf14).Jul 9 2015, 2:00 PM

The API part of this is done with the merge of Lego's patch. Does anyone want to keep it open for backporting to 1.25.$NEXT or for making ForeignAPIFile more robust against this issue?

demon triaged this task as Medium priority.Jul 9 2015, 4:29 PM

demon moved this task from Untriaged to Jan 2019 / 1.33.wmf13–14 on the Wikimedia-production-error board.

demon added a subscriber: demon.

Change 223824 had a related patch set uploaded (by Chad):
APIQueryImageInfo: Set META_BC_BOOLS for 'value' in 'metadata' block

https://gerrit.wikimedia.org/r/223824

Backported to 1.25 in above ^

Change 223824 merged by jenkins-bot:
APIQueryImageInfo: Set META_BC_BOOLS for 'value' in 'metadata' block

https://gerrit.wikimedia.org/r/223824

demon mentioned this in rMW438c7d8cc02f: APIQueryImageInfo: Set META_BC_BOOLS for 'value' in 'metadata' block.Jul 9 2015, 5:10 PM

Forrestbot added a project: MW-1.25-release.Jul 9 2015, 6:00 PM

Umherirrender closed this task as Resolved.Jul 13 2015, 5:36 PM

demon moved this task from Jan 2019 / 1.33.wmf13–14 to Resolved on the Wikimedia-production-error board.Jul 13 2015, 6:28 PM