Set $wgPreloadJavaScriptMwUtil back to false on WMF wikis
Closed, InvalidPublic
Actions

Assigned To

Authored By

	He7d3r
	Jun 25 2015, 9:41 AM

Description

When Resource Loader was introduced, it was necessary to create $wgPreloadJavaScriptMwUtil and set it to true on WMF wikis to reduce the breakage of scripts until they are fixed by their authors. This was back in 2012. Quoting the description of the flag:

Set to true if your wiki has a large amount of user/site scripts that are lacking dependency information. In the short to medium term these user/site scripts should be fixed by adding the used modules to the dependencies in the module registry and/or wrapping them in a callback to mw.loader.using.

It is 2015 already, so it is probably time to reconsider the value for this variable (the "short term" is long gone).

Related Objects

Mentioned In: T111077: Remove $wgPreloadJavaScriptMwUtil

Event Timeline

He7d3r created this task.Jun 25 2015, 9:41 AM

He7d3r raised the priority of this task from to Needs Triage.

He7d3r updated the task description. (Show Details)

He7d3r added projects: JavaScript, Wikimedia-Site-requests.

He7d3r subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2015, 9:41 AM

Krenair added subscribers: Krenair, Krinkle.Jun 25 2015, 4:11 PM

We recently disabled jQuery.mwExtension, and that hasn't really given me much confidence that said scripts have been fixed... Anyone got ideas on if we can do some measuring and encouragement in any way ?

Restricted Application added a subscriber: Matanya. · View Herald TranscriptJun 25 2015, 8:33 PM

Default value of $wgPreloadJavaScriptMwUtil is false, I find only a $wgPreloadJavaScriptMwUtil = true in the labs variante of CommonSettings-labs.php. Maybe this is already set to false in production? It seems like that for me.

Hmmm, but how else could we avoid loading it on top
https://github.com/wikimedia/mediawiki/blob/15465225326e89faa70e1ba43f3c1986e291876c/resources/Resources.php#L1200
?

Maybe only by following the suggestion at
https://github.com/wikimedia/mediawiki/blob/799ca9856b52fb52b2d7d2356df109352eddd707/includes/DefaultSettings.php#L3559-L3561
to deprecate the config itself?

Umherirrender unsubscribed.Jul 5 2015, 7:10 PM

krenair@tin:~$ mwscript eval.php testwiki
> var_dump( $wgPreloadJavaScriptMwUtil );
bool(false)

He7d3r mentioned this in T111077: Remove $wgPreloadJavaScriptMwUtil.Sep 1 2015, 5:17 PM

Set $wgPreloadJavaScriptMwUtil back to false on WMF wikisClosed, InvalidPublicActions

Description

Related Objects

Event Timeline

Set $wgPreloadJavaScriptMwUtil back to false on WMF wikis
Closed, InvalidPublic
Actions