Page MenuHomePhabricator

cxserver configuration stanzas have become unwieldy
Closed, ResolvedPublic1 Estimated Story Points

Description

Looking at:
https://phabricator.wikimedia.org/diffusion/OPUP/browse/production/hieradata/common/cxserver.yaml

it seems that this file has become somewhat unyieldy. ops have only a vague clue about what lines 2-633 do but have to routinely merge changes to this file. The yaml block format used is also quite unreadable at this size. The inline format would already make this file way more readable and reduce the likelihood of errors, but an unnecessary request to ops and a need to for some coordination to routinely merge changes in this file would still exist.

My suggestion would be to go the parsoid way and move such configuration into the cxserver repo. It would mean various small changes both in cxserver code and in puppet code but it would decouple the puppet repo (and ops) from non infrastructure critical configuration changes. That being said, there are parts like logstash configuration that should stay in the puppet repo.

Details

Event Timeline

akosiaris raised the priority of this task from to Needs Triage.
akosiaris updated the task description. (Show Details)
akosiaris subscribed.

When T101272 gets addressed, this could be rather simplified - the production-important info could be in ops/puppet with a config stanza pointing to a file in the repo containing the language translation info.

I actively tried to not couple the 2 tasks in order to not create unnecessary dependencies, but if it makes everyone's life easier to do so, I am all up for it.

KartikMistry triaged this task as Medium priority.
KartikMistry added a project: LE-CX6-Sprint 1.
KartikMistry set Security to None.
KartikMistry moved this task from Backlog to In Progress on the LE-CX6-Sprint 1 board.

This is fixed in Beta and seems working fine. I'll submit patch for Production now.

Change 232018 had a related patch set uploaded (by KartikMistry):
cxserver: Use registry from cxserver repository

https://gerrit.wikimedia.org/r/232018

Change 232018 merged by Alexandros Kosiaris:
cxserver: Use registry from cxserver repository

https://gerrit.wikimedia.org/r/232018

KartikMistry moved this task from In Review to Done on the LE-CX6-Sprint 2 board.
KartikMistry removed a project: Patch-For-Review.