| • Niedzielski | |
| Jun 26 2015, 2:33 AM |
| F1903232: Screenshot_2015-08-19-13-17-22.png | |
| Aug 19 2015, 8:42 PM |
| F1903234: Screenshot_2015-08-19-13-17-39.png | |
| Aug 19 2015, 8:42 PM |
| F711720: Screen Shot 2015-08-07 at 9.22.34 AM.png | |
| Aug 7 2015, 1:26 PM |
| F183625: screenshot-2015-06-25-20-30-42-531147502.png | |
| Jun 26 2015, 2:33 AM |
The "select all" and "web search" buttons are confusing and/or unnecessary. We should remove them from the CAB when highlighting text in the WebView.
The "web search" option presented after highlight text is confusing. I'm in the Wikipedia app, is web search internal? Here are some alternative ideas for discussion:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Hide the "select all" and "web search" CAB menu items | apps/android/wikipedia | master | +19 -2 |
This feels like the perfect interaction for presenting a Wiktionary definition of the word inside a "preview" card, much like the Kindle app does. Once we implement something like that, we can safely remove the "web search" option.
Until then, perhaps another possibility might be to rename it to just "Search", and pass the highlighted text into our own Search field.
Change 228857 had a related patch set uploaded (by Mholloway):
Hide "select all" and "web search" contextual action bar items
For the record, I actually find the web search feature useful in principle, but the patch removes both items as specified.
I vote for keeping the search since I use it occasionally. I don't mind it going to the browser. But removing "Select all" sounds good.
The use cases that I can see justifying web search as is are when I want current events-type information about a given term, or want to see what other kinds of content are out there on the web about that term. Say, for instance, I'm reading the article on Donald Trump and see the former name of his firm, Elizabeth Trump & Son, and want to see what Google turns up for it. This can currently be done from the CAB, but after this patch becomes much more difficult. Or maybe I just want to see the latest headlines on the Donald -- the same applies. In both cases, I'm after distinctly different kinds of content than what I would get from running the equivalent search in Wikipedia.
There's an argument (that I'm less than comfortable with) for taking out web search for the sake of encouraging continued engagement with the app itself, but I think that's a different issue.
Change 228857 merged by jenkins-bot:
Hide the "select all" and "web search" CAB menu items
In the left to right order - do you think Share can appear before Copy?
Any issues with saying
Share > Copy > Overflow Menu
Rationale: Most important actions appear first in the LTR order
Dbrant said that the switch will be complex since these are system actions. Signed off by design in its current state.
Checked with 2.0.108-alpha-2015-08-19 on Nexus5(Android 5.1)
Notice that in landscape position, Copy and Share icons are displayed with their titles.
