Page MenuHomePhabricator
Create Task
Maniphest T103974

Special:Gather/all/recent pagination is broken without JS
Closed, ResolvedPublic
Actions

Description

After all the testing on T103496 we've noticed that with JS disabled the pagination on the collections list on /all/recent is broken because it redirects you to /all/public for the pages after the first one.

This is a use case not many people should encounter but we have to fix it.

This would entail using the $mode of a models\CollectionsList when constructing the views\CollectionsList's pagination button url.

Note: Test carefully without js Special:Gather/by/USERNAME Special:Gather/all/public and Special:Gather/all/recent. Pagination should work in all those 3 urls. See T103496 for how to create lots of collections to see the pagination.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Gathermaster+1 -1Fix broken pagination when JS is disabled
Customize query in gerrit

Related Objects

Event Timeline

Jhernandez created this task.Jun 26 2015, 10:27 AM
Jhernandez raised the priority of this task from to Low.
Jhernandez updated the task description. (Show Details)
Jhernandez added a project: Reading-Web-Sprint-50-The-X-Files.
Jhernandez moved this task to To Do on the Reading-Web-Sprint-50-The-X-Files board.
Jhernandez added a subscriber: Jhernandez.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2015, 10:27 AM
Jhernandez mentioned this in T103496: Special:Gather/all/recent pagination is broken.Jun 26 2015, 10:29 AM
Jhernandez added a subscriber: Niharika.Jun 26 2015, 10:37 AM

cc/ @NiharikaKohli If you want to touch a bit the php part of the Gather extension this should be an easy task and a follow up to the previous patches you've submitted.

Thanks a lot for your help!!

Niharika added a comment.Jun 26 2015, 12:49 PM

@Jhernandez, thanks! I'm trying to replicate the bug. Happy to help. Perfect learning opportunity. :)

gerritbot added a subscriber: gerritbot.Jun 26 2015, 3:13 PM

Change 221132 had a related patch set uploaded (by Niharika29):
Fix broken pagination when JS is disabled

https://gerrit.wikimedia.org/r/221132

gerritbot added a project: Patch-For-Review.Jun 26 2015, 3:13 PM
Niharika claimed this task.Jun 26 2015, 3:16 PM
Niharika set Security to None.
Jdlrobson moved this task from To Do to Code Review on the Reading-Web-Sprint-50-The-X-Files board.Jun 26 2015, 5:01 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-50-The-X-Files board.Jun 26 2015, 5:48 PM
gerritbot added a comment.Jun 26 2015, 5:53 PM

Change 221132 merged by jenkins-bot:
Fix broken pagination when JS is disabled

https://gerrit.wikimedia.org/r/221132

Niharika mentioned this in rMEXTd32975deb71d: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Jun 26 2015, 5:54 PM
Niharika mentioned this in rEGAT923c52475c56: Fix broken pagination when JS is disabled.
phuedx closed this task as Resolved.Jun 26 2015, 7:02 PM
phuedx added a subscriber: phuedx.

Verified on BC on /all/recent, /all/public, and /by/Jdlrobson – Jdlrobson has a lot of test cases.

phuedx moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-50-The-X-Files board.Jun 26 2015, 7:02 PM
phuedx mentioned this in T96864: Update API query continuation usage in Gather for future change of default.Jun 26 2015, 7:09 PM
phuedx removed a project: Patch-For-Review.Jul 6 2015, 6:49 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL