Page MenuHomePhabricator

API improvements to Hovercards
Closed, ResolvedPublic

Description

ext.popups.renderer.article.js

  • Requests the "info" property inprop=watched, but never tests for "watched". Why request it?
  • Doesn't seem to use any of the prop=info properties (contentmodel, pagelanguage, touched, lastrevid, and length). I think it could stop and drop that prop, it's a NOP :)

Brad Jorsch points out instead of requesting indexpageids=true in order to "Include an additional pageids section listing all returned page IDs", Popups could request formatversion=2 which returns "pages" in the query result as an array, simplifying the logic. Instead of

re.query.pages[ re.query.pageids[ 0 ] ].extract

just

re.query.pages[0].extract

etc.

Event Timeline

Spage raised the priority of this task from to Needs Triage.
Spage updated the task description. (Show Details)
Spage added subscribers: Spage, Anomie, Prtksxna.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2015, 10:58 AM

Change 221097 had a related patch set uploaded (by Spage):
API query improvements

https://gerrit.wikimedia.org/r/221097

Change 221097 merged by jenkins-bot:
API query improvements

https://gerrit.wikimedia.org/r/221097

Prtksxna closed this task as Resolved.Jun 30 2015, 6:20 AM
Prtksxna reopened this task as Open.
Prtksxna closed this task as Resolved.
Prtksxna claimed this task.
Prtksxna reassigned this task from Prtksxna to Spage.

Is there no way to assign the task to the right person once the task is closed?
Anyway, re-opened and changed it this time, sorry for the spam!

Is there no way to assign the task to the right person once the task is closed?

From Edit Task, find Assigned To, click on ×, type the new username, click on the autocomplete, then Save Task.

Ricordisamoa set Security to None.

From Edit Task, find Assigned To, click on ×, type the new username, click on the autocomplete, then Save Task.

Ah! I realized after posting this that I could have used Edit Task. I was trying to do it using the comment form. Thanks @Ricordisamoa!