Page MenuHomePhabricator

Populate rev_content_model and rev_content_format when saving
Closed, DeclinedPublic

Description

We currently don't populate rev_content_* when saving if they are the default in order to save space, however this prevents changing of the default.

Event Timeline

Legoktm claimed this task.
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)

Change 221306 had a related patch set uploaded (by Legoktm):
Always populate rev_content_* fields when saving

https://gerrit.wikimedia.org/r/221306

The complexity of this task has escalated to a schema change RFC: https://www.mediawiki.org/wiki/Requests_for_comment/Content_model_storage

The RFC has been approved and implemented:
T105652: RfC: Content model storage

What is the status of this task and https://gerrit.wikimedia.org/r/221306?

The complexity of this task has escalated to a schema change RFC: https://www.mediawiki.org/wiki/Requests_for_comment/Content_model_storage

The RFC has been approved and implemented:
T105652: RfC: Content model storage

What is the status of this task and https://gerrit.wikimedia.org/r/221306?

I don't know. @Legoktm, do you know?

Also, when you say the RFC was implemented, when/where did that happen? I can't find a link to a Gerrit change in the usual places.

Actually it was never implemented, because it was likely to just be extra work that MCR would then change again. And given the amount of progress on MCR so far it seems unlikely to make sense to do this separately. Does that sound right @daniel ?

Change 221306 abandoned by Legoktm:
Always populate rev_content_* fields when saving

Reason:
Obsolete

https://gerrit.wikimedia.org/r/221306

DannyS712 added a subscriber: DannyS712.

Use rev_content_format and rev_content_model is deprecated since 1.31, see https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/423060/ for when this was noted, and T174023: Implement MCR storage layer for more context